From 543af2112be4f255861d42b7481a5f30499ee356 Mon Sep 17 00:00:00 2001 From: anushkagupta200615-jpg Date: Tue, 14 Jul 2026 02:06:07 +0530 Subject: [PATCH] fix: address final review comments on error handling and build tags Signed-off-by: anushkagupta200615-jpg --- internal/plugin/installer/oci_installer.go | 4 +++- internal/plugin/installer/oci_installer_unix_test.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/plugin/installer/oci_installer.go b/internal/plugin/installer/oci_installer.go index 675fbde8c..ea9e16262 100644 --- a/internal/plugin/installer/oci_installer.go +++ b/internal/plugin/installer/oci_installer.go @@ -222,7 +222,9 @@ func extractFile(path string, mode int64, src io.Reader) error { } if _, err := io.Copy(outFile, src); err != nil { - outFile.Close() + if cErr := outFile.Close(); cErr != nil { + return fmt.Errorf("%w (also failed to close: %v)", err, cErr) + } return err } diff --git a/internal/plugin/installer/oci_installer_unix_test.go b/internal/plugin/installer/oci_installer_unix_test.go index 7fb9876da..90cba1631 100644 --- a/internal/plugin/installer/oci_installer_unix_test.go +++ b/internal/plugin/installer/oci_installer_unix_test.go @@ -1,4 +1,4 @@ -//go:build !windows +//go:build unix /* Copyright The Helm Authors.