diff --git a/cmd/helm/package.go b/cmd/helm/package.go index c64784ef4..880b11fe4 100644 --- a/cmd/helm/package.go +++ b/cmd/helm/package.go @@ -54,21 +54,25 @@ func runPackage(cmd *cobra.Command, args []string) error { return err } - // Save to $HELM_HOME/local directory. - if save { - if err := repo.AddChartToLocalRepo(ch, localRepoDirectory()); err != nil { - return err - } - } - // Save to the current working directory. cwd, err := os.Getwd() if err != nil { return err } name, err := chart.Save(ch, cwd) - if err == nil { + if err == nil && flagVerbose { cmd.Printf("Saved %s to current directory\n", name) } + + // Save to $HELM_HOME/local directory. This is second, because we don't want + // the case where we saved here, but didn't save to the default destination. + if save { + if err := repo.AddChartToLocalRepo(ch, localRepoDirectory()); err != nil { + return err + } else if flagVerbose { + cmd.Printf("Saved %s to %s\n", name, localRepoDirectory()) + } + } + return err } diff --git a/pkg/repo/local.go b/pkg/repo/local.go index 30fdab42d..04b73f7f3 100644 --- a/pkg/repo/local.go +++ b/pkg/repo/local.go @@ -43,7 +43,7 @@ func serveFile(w http.ResponseWriter, r *http.Request, file string) { // AddChartToLocalRepo saves a chart in the given path and then reindexes the index file func AddChartToLocalRepo(ch *chart.Chart, path string) error { - name, err := chart.Save(ch, path) + _, err := chart.Save(ch, path) if err != nil { return err } @@ -51,7 +51,6 @@ func AddChartToLocalRepo(ch *chart.Chart, path string) error { if err != nil { return err } - fmt.Printf("Saved %s to $HELM_HOME/local", name) return nil }