From 52235cc0bf7d0c8faf17c7dc8cddd77f93434aea Mon Sep 17 00:00:00 2001
From: Manuel Alonso <434575+manute@users.noreply.github.com>
Date: Wed, 26 Nov 2025 18:33:20 +0100
Subject: [PATCH] fix(install): check lenght and file nil, add tests

Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
---
 pkg/action/install.go      |  6 +++++-
 pkg/action/install_test.go | 40 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/pkg/action/install.go b/pkg/action/install.go
index b0c28132a..b2e8f8bf4 100644
--- a/pkg/action/install.go
+++ b/pkg/action/install.go
@@ -180,13 +180,17 @@ func (i *Install) installCRDs(crds []chart.CRD) error {
 	// We do these one file at a time in the order they were read.
 	totalItems := []*resource.Info{}
 	for _, obj := range crds {
+		if obj.File == nil {
+			return fmt.Errorf("failed to install CRD %s: file is empty", obj.Name)
+		}
+
 		// Read in the resources
 		res, err := i.cfg.KubeClient.Build(bytes.NewBuffer(obj.File.Data), false)
 		if err != nil {
 			return fmt.Errorf("failed to install CRD %s: %w", obj.Name, err)
 		}
 
-		if res == nil {
+		if len(res) == 0 {
 			return fmt.Errorf("failed to install CRD %s: resources are empty", obj.Name)
 		}
 
diff --git a/pkg/action/install_test.go b/pkg/action/install_test.go
index 9f04f40d4..a9a33881a 100644
--- a/pkg/action/install_test.go
+++ b/pkg/action/install_test.go
@@ -45,6 +45,7 @@ import (
 
 	"helm.sh/helm/v4/internal/test"
 	"helm.sh/helm/v4/pkg/chart/common"
+	chart "helm.sh/helm/v4/pkg/chart/v2"
 	"helm.sh/helm/v4/pkg/kube"
 	kubefake "helm.sh/helm/v4/pkg/kube/fake"
 	rcommon "helm.sh/helm/v4/pkg/release/common"
@@ -1068,3 +1069,42 @@ func TestInstallRun_UnreachableKubeClient(t *testing.T) {
 	assert.Nil(t, res)
 	assert.ErrorContains(t, err, "connection refused")
 }
+
+func TestInstallCRDs_CheckNilErrors(t *testing.T) {
+	tests := []struct {
+		name  string
+		input []chart.CRD
+	}{
+		{
+			name: "only one crd with file nil",
+			input: []chart.CRD{
+				{Name: "one", File: nil},
+			},
+		},
+		{
+			name: "only one crd with its file data nil",
+			input: []chart.CRD{
+				{Name: "one", File: &common.File{Name: "crds/foo.yaml", Data: nil}},
+			},
+		},
+		{
+			name: "at least a crd with its file data nil",
+			input: []chart.CRD{
+				{Name: "one", File: &common.File{Name: "crds/foo.yaml", Data: []byte("data")}},
+				{Name: "two", File: &common.File{Name: "crds/foo.yaml", Data: nil}},
+				{Name: "three", File: &common.File{Name: "crds/foo.yaml", Data: []byte("data")}},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			instAction := installAction(t)
+
+			err := instAction.installCRDs(tt.input)
+			if err == nil {
+				t.Errorf("got error expected nil")
+			}
+		})
+	}
+}