From 4ea18537d02763ceb5b6c57557da1322f96daeaf Mon Sep 17 00:00:00 2001 From: Nermin Sehovic Date: Sun, 2 Jan 2022 17:57:07 +0100 Subject: [PATCH] Initial fix for helm test logs filter issue Signed-off-by: Nermin Sehovic --- pkg/action/release_testing.go | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/pkg/action/release_testing.go b/pkg/action/release_testing.go index ecaeaf59f..d1f0d91cb 100644 --- a/pkg/action/release_testing.go +++ b/pkg/action/release_testing.go @@ -107,6 +107,30 @@ func (r *ReleaseTesting) GetPodLogs(out io.Writer, rel *release.Release) error { return errors.Wrap(err, "unable to get kubernetes client to fetch pod logs") } + skippedHooks := []*release.Hook{} + executingHooks := []*release.Hook{} + if len(r.Filters["!name"]) != 0 { + for _, h := range rel.Hooks { + if contains(r.Filters["!name"], h.Name) { + skippedHooks = append(skippedHooks, h) + } else { + executingHooks = append(executingHooks, h) + } + } + rel.Hooks = executingHooks + } + if len(r.Filters["name"]) != 0 { + executingHooks = nil + for _, h := range rel.Hooks { + if contains(r.Filters["name"], h.Name) { + executingHooks = append(executingHooks, h) + } else { + skippedHooks = append(skippedHooks, h) + } + } + rel.Hooks = executingHooks + } + for _, h := range rel.Hooks { for _, e := range h.Events { if e == release.HookTest {