Merge pull request #1074 from michelleN/feat/1004-helm-rollback

feat(helm): add rollback cmd
pull/1081/head
Michelle Noorali 8 years ago committed by GitHub
commit 4dfcd6fcb7

@ -93,6 +93,7 @@ func newRootCmd(out io.Writer) *cobra.Command {
newListCmd(nil, out),
newStatusCmd(nil, out),
newUpgradeCmd(nil, out),
newRollbackCmd(nil, out),
)
return cmd
}

@ -124,18 +124,18 @@ sailor: sinbad
// Combined case, overriding a property
vals["sailor"] = "pisti"
updated_yaml := `good: true
updatedYAML := `good: true
port:
destination: basrah
source: baghdad
sailor: pisti
`
new_out, err := vobj.yaml()
newOut, err := vobj.yaml()
if err != nil {
t.Fatal(err)
}
if string(new_out) != updated_yaml {
t.Errorf("Expected YAML to be \n%s\nGot\n%s\n", updated_yaml, new_out)
if string(newOut) != updatedYAML {
t.Errorf("Expected YAML to be \n%s\nGot\n%s\n", updatedYAML, newOut)
}
}

@ -0,0 +1,76 @@
/*
Copyright 2016 The Kubernetes Authors All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package main
import (
"fmt"
"io"
"github.com/spf13/cobra"
"k8s.io/helm/pkg/helm"
)
const rollbackDesc = `
This command rolls back a release to the previous version.
The rollback argument is the name of a release.
`
type rollbackCmd struct {
name string
dryRun bool
disableHooks bool
out io.Writer
client helm.Interface
}
func newRollbackCmd(c helm.Interface, out io.Writer) *cobra.Command {
rollback := &rollbackCmd{
out: out,
client: c,
}
cmd := &cobra.Command{
Use: "rollback [RELEASE]",
Short: "roll back a release to the previous version",
Long: rollbackDesc,
PersistentPreRunE: setupConnection,
RunE: func(cmd *cobra.Command, args []string) error {
if err := checkArgsLength(1, len(args), "release name"); err != nil {
return err
}
rollback.client = ensureHelmClient(rollback.client)
return rollback.run()
},
}
f := cmd.Flags()
f.BoolVar(&rollback.dryRun, "dry-run", false, "simulate an install")
f.BoolVar(&rollback.disableHooks, "no-hooks", false, "prevent hooks from running during rollback")
return cmd
}
func (r *rollbackCmd) run() error {
msg := "This command is under construction. Coming soon to a Helm near you!"
fmt.Fprintf(r.out, msg)
return nil
}

@ -0,0 +1,43 @@
/*
Copyright 2016 The Kubernetes Authors All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package main
import (
"io"
"testing"
"github.com/spf13/cobra"
)
func TestRollbackCmd(t *testing.T) {
tests := []releaseCase{
{
name: "rollback a release",
args: []string{"funny-honey"},
resp: nil,
expected: "This command is under construction. Coming soon to a Helm near you!",
},
}
cmd := func(c *fakeReleaseClient, out io.Writer) *cobra.Command {
return newRollbackCmd(c, out)
}
runReleaseCases(t, tests, cmd)
}
Loading…
Cancel
Save