From 4c226b67f946f71311d117fc2f86f63bcff09d83 Mon Sep 17 00:00:00 2001
From: SataQiu <qiushida@beyondcent.com>
Date: Wed, 23 Jan 2019 16:45:18 +0800
Subject: [PATCH] add plugin load warnings

Signed-off-by: SataQiu <qiushida@beyondcent.com>
---
 cmd/helm/load_plugins.go | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/cmd/helm/load_plugins.go b/cmd/helm/load_plugins.go
index caac1b7a3..1f2a08131 100644
--- a/cmd/helm/load_plugins.go
+++ b/cmd/helm/load_plugins.go
@@ -23,12 +23,22 @@ import (
 	"path/filepath"
 	"strings"
 	"syscall"
+	"text/template"
 
 	"github.com/spf13/cobra"
 
 	"k8s.io/helm/pkg/plugin"
 )
 
+var pluginLoadWarningTemp = template.Must(template.New("plugin").Parse(`
+Helm Client Plugin Load Warning(s):
+{{range $_, $warning := .Warnings}}
+- {{ $warning }}
+{{end}}
+In order to eliminate this warning(s), please try to uninstall or reinstall the plugin(s) in question.
+------------------------------------------------------------------------------------------------------
+`))
+
 type pluginError struct {
 	error
 	code int
@@ -62,6 +72,7 @@ func loadPlugins(baseCmd *cobra.Command, out io.Writer) {
 	}
 
 	// Now we create commands for all of these.
+	warnings := []string{}
 loop:
 	for _, plug := range found {
 		plug := plug
@@ -121,11 +132,19 @@ loop:
 		// Make sure a command with this name does not already exist.
 		for _, cmd := range baseCmd.Commands() {
 			if cmd.Name() == md.Name {
+				warning := fmt.Sprintf("A command with the name of [%s] already exists, so the plugin at [%s] will not be loaded.", md.Name, plug.Dir)
+				warnings = append(warnings, warning)
 				continue loop
 			}
 		}
 		baseCmd.AddCommand(c)
 	}
+
+	ctx := map[string]interface{}{
+		"Warnings": warnings,
+	}
+
+	pluginLoadWarningTemp.Execute(out, ctx)
 }
 
 // manuallyProcessArgs processes an arg array, removing special args.