From 2f63045f259c98187b61b00529895117c05bb02f Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Wed, 7 Jul 2021 10:53:35 -0500 Subject: [PATCH 1/5] Add build-pr github actions workflow Signed-off-by: Josh Dolitsky --- .github/workflows/build-pr.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/build-pr.yml diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml new file mode 100644 index 000000000..ecb85f62e --- /dev/null +++ b/.github/workflows/build-pr.yml @@ -0,0 +1,26 @@ +name: build-pr +on: + pull_request: + branches: + - main +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout source code + uses: actions/checkout@v2 + - name: Setup Go + uses: actions/setup-go@v1 + with: + go-version: '1.16' + - name: Install golangci-lint + run: | + curl -sSL https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | tar xz + sudo mv golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64/golangci-lint /usr/local/bin/golangci-lint + rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64 + env: + GOLANGCI_LINT_VERSION: '1.36.0' + - name: Test style + run: make test-style + - name: Run unit tests + run: make test-coverage From 7605db034de36dc991871c1eb90030f88c484dc0 Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Wed, 7 Jul 2021 12:19:59 -0500 Subject: [PATCH 2/5] Use setup-go v2 Signed-off-by: Josh Dolitsky --- .github/workflows/build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index ecb85f62e..e94efbbf9 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -10,7 +10,7 @@ jobs: - name: Checkout source code uses: actions/checkout@v2 - name: Setup Go - uses: actions/setup-go@v1 + uses: actions/setup-go@v2 with: go-version: '1.16' - name: Install golangci-lint From b16091a01a9c32164a9c9eb3879b8c4933c133d4 Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Thu, 8 Jul 2021 09:59:23 -0500 Subject: [PATCH 3/5] verify golangci-lint sha256 checksum Signed-off-by: Josh Dolitsky --- .github/workflows/build-pr.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index e94efbbf9..d35be3f4b 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -15,11 +15,14 @@ jobs: go-version: '1.16' - name: Install golangci-lint run: | - curl -sSL https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | tar xz + curl -sSLO https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz + shasum -a 256 golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | grep "^$GOLANGCI_LINT_SHA256 " > /dev/null + tar -xf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz sudo mv golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64/golangci-lint /usr/local/bin/golangci-lint - rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64 + rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64* env: GOLANGCI_LINT_VERSION: '1.36.0' + GOLANGCI_LINT_SHA256: '9b8856b3a1c9bfbcf3a06b78e94611763b79abd9751c245246787cd3bf0e78a5' - name: Test style run: make test-style - name: Run unit tests From 07a25a26f62e55a6e05a5d701590368c212a4c14 Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Thu, 8 Jul 2021 10:06:16 -0500 Subject: [PATCH 4/5] Use official golangci-lint action Signed-off-by: Josh Dolitsky --- .github/workflows/build-pr.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index d35be3f4b..34f4061c1 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -12,17 +12,11 @@ jobs: - name: Setup Go uses: actions/setup-go@v2 with: - go-version: '1.16' + go-version: 1.16 - name: Install golangci-lint - run: | - curl -sSLO https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz - shasum -a 256 golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | grep "^$GOLANGCI_LINT_SHA256 " > /dev/null - tar -xf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz - sudo mv golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64/golangci-lint /usr/local/bin/golangci-lint - rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64* - env: - GOLANGCI_LINT_VERSION: '1.36.0' - GOLANGCI_LINT_SHA256: '9b8856b3a1c9bfbcf3a06b78e94611763b79abd9751c245246787cd3bf0e78a5' + uses: golangci/golangci-lint-action@v2 + with: + version: v1.36.0 - name: Test style run: make test-style - name: Run unit tests From 28f44b82691f71220f610bfaa1f544f49253a2bd Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Thu, 8 Jul 2021 10:10:37 -0500 Subject: [PATCH 5/5] Revert "Use official golangci-lint action" Signed-off-by: Josh Dolitsky --- .github/workflows/build-pr.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index 34f4061c1..d35be3f4b 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -12,11 +12,17 @@ jobs: - name: Setup Go uses: actions/setup-go@v2 with: - go-version: 1.16 + go-version: '1.16' - name: Install golangci-lint - uses: golangci/golangci-lint-action@v2 - with: - version: v1.36.0 + run: | + curl -sSLO https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCI_LINT_VERSION/golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz + shasum -a 256 golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz | grep "^$GOLANGCI_LINT_SHA256 " > /dev/null + tar -xf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64.tar.gz + sudo mv golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64/golangci-lint /usr/local/bin/golangci-lint + rm -rf golangci-lint-$GOLANGCI_LINT_VERSION-linux-amd64* + env: + GOLANGCI_LINT_VERSION: '1.36.0' + GOLANGCI_LINT_SHA256: '9b8856b3a1c9bfbcf3a06b78e94611763b79abd9751c245246787cd3bf0e78a5' - name: Test style run: make test-style - name: Run unit tests