From 48f19e84fcc322e912061c48597768d61c082cad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johnny=20Bergstr=C3=B6m?= Date: Tue, 20 Feb 2018 15:42:08 +0100 Subject: [PATCH] Update rollback test - Add logging - Verify other release names not changed --- pkg/tiller/release_rollback_test.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/pkg/tiller/release_rollback_test.go b/pkg/tiller/release_rollback_test.go index 4022fd107..b73501a36 100644 --- a/pkg/tiller/release_rollback_test.go +++ b/pkg/tiller/release_rollback_test.go @@ -139,6 +139,11 @@ func TestRollbackRelease(t *testing.T) { func TestRollbackWithReleaseVersion(t *testing.T) { c := helm.NewContext() rs := rsFixture() + rs.Log = t.Logf + rs.env.Releases.Log = t.Logf + rel2 := releaseStub() + rel2.Name = "other" + rs.env.Releases.Create(rel2) rel := releaseStub() rs.env.Releases.Create(rel) v2 := upgradeReleaseVersion(rel) @@ -169,6 +174,14 @@ func TestRollbackWithReleaseVersion(t *testing.T) { if oldRel.Info.Status.Code != release.Status_SUPERSEDED { t.Errorf("Expected v2 to be in a SUPERSEDED state, got %q", oldRel.Info.Status.Code) } + // make sure we didn't update some other deployments. + otherRel, err := rs.env.Releases.Get(rel2.Name, 1) + if err != nil { + t.Fatalf("Failed to retrieve other v1: %s", err) + } + if otherRel.Info.Status.Code != release.Status_DEPLOYED { + t.Errorf("Expected other deployed release to stay untouched, got %q", otherRel.Info.Status.Code) + } } func TestRollbackReleaseNoHooks(t *testing.T) {