From 4880a6e1064318530cf596b990d8cf0cc89b66da Mon Sep 17 00:00:00 2001 From: Henry Nash Date: Wed, 5 Dec 2018 09:05:51 +0000 Subject: [PATCH] docs(helm): Mention commit signing in the Developer Guide This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes #5016 Signed-off-by: Henry Nash --- docs/developers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developers.md b/docs/developers.md index 4f1da2d96..4edc4bea1 100644 --- a/docs/developers.md +++ b/docs/developers.md @@ -167,7 +167,7 @@ workflow for doing this is as follows: 3. Add your repository as a remote for `$GOPATH/src/k8s.io/helm` 4. Create a new working branch (`git checkout -b feat/my-feature`) and do your work on that branch. -5. When you are ready for us to review, push your branch to GitHub, and +5. When you are ready for us to review, sign your commit, push your branch to GitHub, and then open a new pull request with us. For Git commit messages, we follow the [Semantic Commit Messages](http://karma-runner.github.io/0.13/dev/git-commit-msg.html):