From 427e1c76e1aeb40cfd5fb5519c2a0d6eb70fa1f7 Mon Sep 17 00:00:00 2001 From: Ilya Saulenko Date: Mon, 16 Oct 2017 18:49:56 +0300 Subject: [PATCH] feat(tiller): add -prometheus-histograms flag When Tiller is started with -prometheus-histograms flag, goprom.EnableHandlingTimeHistogram() is used to enable RPC request latencies reporting via Prometheus historgrams. --- cmd/tiller/tiller.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cmd/tiller/tiller.go b/cmd/tiller/tiller.go index f18ce6c3d..65720508b 100644 --- a/cmd/tiller/tiller.go +++ b/cmd/tiller/tiller.go @@ -69,6 +69,7 @@ const ( var ( grpcAddr = flag.String("listen", ":44134", "address:port to listen on") enableTracing = flag.Bool("trace", false, "enable rpc tracing") + enableHistograms = flag.Bool("prometheus-histograms", false, "enable reporting of RPC request latencies via prometheus histograms") store = flag.String("storage", storageConfigMap, "storage driver to use. One of 'configmap', 'memory', or 'secret'") remoteReleaseModules = flag.Bool("experimental-release", false, "enable experimental release modules") tlsEnable = flag.Bool("tls", tlsEnableEnvVarDefault(), "enable TLS") @@ -183,6 +184,12 @@ func start() { // Register gRPC server to prometheus to initialized matrix goprom.Register(rootServer) + + if *enableHistograms { + goprom.EnableHandlingTimeHistogram() + logger.Println("Prometheus histograms reporting is enabled") + } + addPrometheusHandler(mux) if err := http.ListenAndServe(probeAddr, mux); err != nil {