From f54886a6146da2051c2b5de8bd89b190a7d36c96 Mon Sep 17 00:00:00 2001 From: Vaibhav Sharma <17532va@gmail.com> Date: Thu, 19 Jan 2023 19:09:45 +0530 Subject: [PATCH 1/3] Added statement on debug Signed-off-by: Vaibhav Sharma <17532va@gmail.com> --- pkg/downloader/manager.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index 18b28dde1..ef0a0d439 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -85,6 +85,10 @@ type Manager struct { // If SkipUpdate is set, this will not update the repository. func (m *Manager) Build() error { c, err := m.loadChartDir() + if c.Metadata.Dependencies == nil && m.Debug { + fmt.Print("No dependencies found to build") + return nil + } if err != nil { return err } From 767eb92f5b92697f71e356310cc941d8205bf916 Mon Sep 17 00:00:00 2001 From: Vaibhav Sharma <17532va@gmail.com> Date: Fri, 20 Jan 2023 13:01:39 +0530 Subject: [PATCH 2/3] Moved the logging after error Signed-off-by: Vaibhav Sharma <17532va@gmail.com> --- pkg/downloader/manager.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index ef0a0d439..1339ff88e 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -85,14 +85,14 @@ type Manager struct { // If SkipUpdate is set, this will not update the repository. func (m *Manager) Build() error { c, err := m.loadChartDir() - if c.Metadata.Dependencies == nil && m.Debug { - fmt.Print("No dependencies found to build") - return nil - } if err != nil { return err } + if c.Metadata.Dependencies == nil && m.Debug { + fmt.Print("No dependencies found to build") + return nil + } // If a lock file is found, run a build from that. Otherwise, just do // an update. lock := c.Lock From 06401650acc1c8e42d916487e3dff1beb67f1101 Mon Sep 17 00:00:00 2001 From: Vaibhav Sharma <17532va@gmail.com> Date: Mon, 1 May 2023 22:00:13 +0530 Subject: [PATCH 3/3] Updated logging Signed-off-by: Vaibhav Sharma <17532va@gmail.com> --- pkg/downloader/manager.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index 1339ff88e..9620a9c82 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -90,7 +90,7 @@ func (m *Manager) Build() error { } if c.Metadata.Dependencies == nil && m.Debug { - fmt.Print("No dependencies found to build") + fmt.Fprintln(m.Out, "No dependencies found to build") return nil } // If a lock file is found, run a build from that. Otherwise, just do