From 3b26ddc22ba4c99292dba724170b2e30a94aebef Mon Sep 17 00:00:00 2001 From: Zach Burgess Date: Tue, 1 Jul 2025 15:29:19 -0700 Subject: [PATCH] Update tests in create_test.go and package_test.go to work in a temp dir. Signed-off-by: Zach Burgess --- pkg/cmd/create_test.go | 8 +++----- pkg/cmd/package_test.go | 3 +-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/pkg/cmd/create_test.go b/pkg/cmd/create_test.go index 103cd3bc0..2a4ca95ca 100644 --- a/pkg/cmd/create_test.go +++ b/pkg/cmd/create_test.go @@ -30,10 +30,9 @@ import ( ) func TestCreateCmd(t *testing.T) { + t.Chdir(t.TempDir()) ensure.HelmHome(t) cname := "testchart" - dir := t.TempDir() - defer t.Chdir(dir) // Run a create if _, _, err := executeActionCommand("create " + cname); err != nil { @@ -64,9 +63,7 @@ func TestCreateStarterCmd(t *testing.T) { ensure.HelmHome(t) cname := "testchart" defer resetEnv()() - os.MkdirAll(helmpath.CachePath(), 0o755) - defer t.Chdir(helmpath.CachePath()) - + t.Chdir(t.TempDir()) // Create a starter. starterchart := helmpath.DataPath("starters") os.MkdirAll(starterchart, 0o755) @@ -125,6 +122,7 @@ func TestCreateStarterCmd(t *testing.T) { } func TestCreateStarterAbsoluteCmd(t *testing.T) { + t.Chdir(t.TempDir()) defer resetEnv()() ensure.HelmHome(t) cname := "testchart" diff --git a/pkg/cmd/package_test.go b/pkg/cmd/package_test.go index b17684aa6..349cb662f 100644 --- a/pkg/cmd/package_test.go +++ b/pkg/cmd/package_test.go @@ -110,8 +110,7 @@ func TestPackage(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { - cachePath := t.TempDir() - defer t.Chdir(cachePath) + t.Chdir(t.TempDir()) if err := os.MkdirAll("toot", 0o777); err != nil { t.Fatal(err)