From 39792b5ad004a99b3ef649a649a0f1834b07a0f6 Mon Sep 17 00:00:00 2001 From: Scott Rigby Date: Thu, 6 Jan 2022 19:10:15 -0500 Subject: [PATCH] Revert "It appears we never got to this block below. Quick rec by Farina. Untested if necessary" This reverts commit f616a01808da3428c6191e5196f32ca72eb22254. Removing for now until we know we need it. Signed-off-by: Scott Rigby --- pkg/downloader/manager.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index c85b0b707..52f1a1312 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -578,7 +578,8 @@ func (m *Manager) resolveRepoNames(deps []*chart.Dependency) (map[string]string, missing := []string{} for _, dd := range deps { // Don't map the repository, we don't need to download chart from charts directory - if dd.Repository == "" { + // When OCI is used there is no Helm repository + if dd.Repository == "" || registry.IsOCI(dd.Repository) { continue } // if dep chart is from local path, verify the path is valid @@ -594,8 +595,6 @@ func (m *Manager) resolveRepoNames(deps []*chart.Dependency) (map[string]string, continue } - // See https://helm.sh/docs/topics/registries/#specifying-dependencies - // See createTestingMetadataForOCI() if registry.IsOCI(dd.Repository) { reposMap[dd.Name] = dd.Repository continue