From 38c3f58dca47a73c9639de6cafd80d8ea3e23912 Mon Sep 17 00:00:00 2001 From: Maxim Ivanov Date: Fri, 22 Sep 2017 11:34:30 +0100 Subject: [PATCH] Correctly persists Release upgrade failure When release upgrade fails, updatedRelease is already created in a storage by *ReleaseServer.UpdateRelease, therefore we should be updating it's status, not creating it again. --- pkg/tiller/release_update.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/tiller/release_update.go b/pkg/tiller/release_update.go index 58a8a18c0..18cf56737 100644 --- a/pkg/tiller/release_update.go +++ b/pkg/tiller/release_update.go @@ -155,7 +155,7 @@ func (s *ReleaseServer) performUpdate(originalRelease, updatedRelease *release.R updatedRelease.Info.Status.Code = release.Status_FAILED updatedRelease.Info.Description = msg s.recordRelease(originalRelease, true) - s.recordRelease(updatedRelease, false) + s.recordRelease(updatedRelease, true) return res, err }