From 374e9d8c7dc49cdd5623d15c794e46a80e3134b5 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Fri, 7 Feb 2020 20:27:39 -0500 Subject: [PATCH] fix(comp): Fix broken completion for --output flag For commands using the new post-render flag, the completion for the --output flag was broken. For example: helm install -o __helm_handle_reply:47: command not found: __helm_output_options The bash __helm_output_options function is no longer used but was referred to by mistake. This commit removes the offending code. Signed-off-by: Marc Khouzam (cherry picked from commit 023bdaec63f3fdb0effcc0cb2ac045a15539c430) --- cmd/helm/flags.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/helm/flags.go b/cmd/helm/flags.go index 86ed53d51..246cb0dd5 100644 --- a/cmd/helm/flags.go +++ b/cmd/helm/flags.go @@ -99,8 +99,6 @@ func (o *outputValue) Set(s string) error { func bindPostRenderFlag(cmd *cobra.Command, varRef *postrender.PostRenderer) { cmd.Flags().Var(&postRenderer{varRef}, postRenderFlag, "the path to an executable to be used for post rendering. If it exists in $PATH, the binary will be used, otherwise it will try to look for the executable at the given path") - // Setup shell completion for the flag - cmd.MarkFlagCustom(outputFlag, "__helm_output_options") } type postRenderer struct {