diff --git a/pkg/kube/client.go b/pkg/kube/client.go index fd111c647..d253f06fd 100644 --- a/pkg/kube/client.go +++ b/pkg/kube/client.go @@ -287,7 +287,7 @@ func (c *Client) Wait(resources ResourceList, timeout time.Duration) error { if err != nil { return err } - checker := NewReadyChecker(cs, c.Log, PausedAsReady(true)) + checker := NewReadyChecker(cs, PausedAsReady(true)) w := waiter{ c: checker, log: c.Log, @@ -302,7 +302,7 @@ func (c *Client) WaitWithJobs(resources ResourceList, timeout time.Duration) err if err != nil { return err } - checker := NewReadyChecker(cs, c.Log, PausedAsReady(true), CheckJobs(true)) + checker := NewReadyChecker(cs, PausedAsReady(true), CheckJobs(true)) w := waiter{ c: checker, log: c.Log, diff --git a/pkg/kube/ready.go b/pkg/kube/ready.go index dd5869e6a..456147c96 100644 --- a/pkg/kube/ready.go +++ b/pkg/kube/ready.go @@ -57,13 +57,9 @@ func CheckJobs(checkJobs bool) ReadyCheckerOption { // NewReadyChecker creates a new checker. Passed ReadyCheckerOptions can // be used to override defaults. -func NewReadyChecker(cl kubernetes.Interface, log func(string, ...interface{}), opts ...ReadyCheckerOption) ReadyChecker { +func NewReadyChecker(cl kubernetes.Interface, opts ...ReadyCheckerOption) ReadyChecker { c := ReadyChecker{ client: cl, - log: log, - } - if c.log == nil { - c.log = nopLogger } for _, opt := range opts { opt(&c) @@ -74,7 +70,6 @@ func NewReadyChecker(cl kubernetes.Interface, log func(string, ...interface{}), // ReadyChecker is a type that can check core Kubernetes types for readiness. type ReadyChecker struct { client kubernetes.Interface - log func(string, ...interface{}) checkJobs bool pausedAsReady bool } diff --git a/pkg/kube/ready_test.go b/pkg/kube/ready_test.go index a8ba05287..2053bf1e2 100644 --- a/pkg/kube/ready_test.go +++ b/pkg/kube/ready_test.go @@ -90,7 +90,6 @@ func Test_ReadyChecker_IsReady_Pod(t *testing.T) { t.Run(tt.name, func(t *testing.T) { c := &ReadyChecker{ client: tt.fields.client, - log: tt.fields.log, checkJobs: tt.fields.checkJobs, pausedAsReady: tt.fields.pausedAsReady, } @@ -166,7 +165,6 @@ func Test_ReadyChecker_IsReady_Job(t *testing.T) { t.Run(tt.name, func(t *testing.T) { c := &ReadyChecker{ client: tt.fields.client, - log: tt.fields.log, checkJobs: tt.fields.checkJobs, pausedAsReady: tt.fields.pausedAsReady, } @@ -244,7 +242,6 @@ func Test_ReadyChecker_IsReady_Deployment(t *testing.T) { t.Run(tt.name, func(t *testing.T) { c := &ReadyChecker{ client: tt.fields.client, - log: tt.fields.log, checkJobs: tt.fields.checkJobs, pausedAsReady: tt.fields.pausedAsReady, } @@ -323,7 +320,6 @@ func Test_ReadyChecker_IsReady_PersistentVolumeClaim(t *testing.T) { t.Run(tt.name, func(t *testing.T) { c := &ReadyChecker{ client: tt.fields.client, - log: tt.fields.log, checkJobs: tt.fields.checkJobs, pausedAsReady: tt.fields.pausedAsReady, } @@ -398,7 +394,6 @@ func Test_ReadyChecker_IsReady_Service(t *testing.T) { t.Run(tt.name, func(t *testing.T) { c := &ReadyChecker{ client: tt.fields.client, - log: tt.fields.log, checkJobs: tt.fields.checkJobs, pausedAsReady: tt.fields.pausedAsReady, }