From 364b4e06777994de7c074e081354a29b021a498b Mon Sep 17 00:00:00 2001 From: Cosmin Cojocar Date: Thu, 23 Aug 2018 09:40:04 +0200 Subject: [PATCH] Restore the state of the skipUpdate flag to the sate before running the recursive build and also add some comments Signed-off-by: Cosmin Cojocar --- pkg/downloader/manager.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go index 2f7a536a9..a9d044512 100644 --- a/pkg/downloader/manager.go +++ b/pkg/downloader/manager.go @@ -126,7 +126,11 @@ func (m *Manager) BuildRecursively() error { return err } + // The local repositories are already updated by the root build. Skip the update + // for each dependent chart to improve performance. + prevSkipUpdate := m.SkipUpdate m.SkipUpdate = true + baseChartPath := filepath.Join(m.ChartPath, "charts") // Do a Breadth-first traversal over the chart dependencies and @@ -161,6 +165,9 @@ func (m *Manager) BuildRecursively() error { } } + // Restore to the original value before running the recursive build + m.SkipUpdate = prevSkipUpdate + return nil }