fix(v3): fix regression on non-zero plugin exist status

Fixes the regression in helm-3.0.0-beta.5 that swallows and rounds any non-zero exit status greater than 1 from a helm plugin to `1`.

This, for example, breaks `helm-diff` which relies on helm able to return `2` when `helm-diff` returned `2`.

Closese #6788

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
pull/6790/head
Yusuke Kuoka 5 years ago
parent 63c6378bf6
commit 3144cf0fed

@ -68,6 +68,11 @@ func main() {
cmd := newRootCmd(actionConfig, os.Stdout, os.Args[1:])
if err := actionConfig.Init(settings, false, os.Getenv("HELM_DRIVER"), debug); err != nil {
debug("%+v", err)
os.Exit(1)
}
if err := cmd.Execute(); err != nil {
debug("%+v", err)
switch e := err.(type) {
case pluginError:
@ -76,11 +81,6 @@ func main() {
os.Exit(1)
}
}
if err := cmd.Execute(); err != nil {
debug("%+v", err)
os.Exit(1)
}
}
// wordSepNormalizeFunc changes all flags that contain "_" separators

Loading…
Cancel
Save