From 5a2b4f944ad2393aeeb4b42d624f1b40680b9c45 Mon Sep 17 00:00:00 2001 From: Andrew Block Date: Sun, 30 Jan 2022 15:31:41 -0600 Subject: [PATCH 1/2] Avoid querying for OCI tags can explicit version provided in chart dependencies Signed-off-by: Andrew Block Signed-off-by: jsolana --- internal/resolver/resolver.go | 38 ++++++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/internal/resolver/resolver.go b/internal/resolver/resolver.go index c9472dfb4..5e8921f96 100644 --- a/internal/resolver/resolver.go +++ b/internal/resolver/resolver.go @@ -135,22 +135,36 @@ func (r *Resolver) Resolve(reqs []*chart.Dependency, repoNames map[string]string found = false } else { version = d.Version - // Retrieve list of tags for repository - ref := fmt.Sprintf("%s/%s", strings.TrimPrefix(d.Repository, fmt.Sprintf("%s://", registry.OCIScheme)), d.Name) - tags, err := r.registryClient.Tags(ref) - if err != nil { - return nil, errors.Wrapf(err, "could not retrieve list of tags for repository %s", d.Repository) - } - vs = make(repo.ChartVersions, len(tags)) - for ti, t := range tags { - // Mock chart version objects - version := &repo.ChartVersion{ + // Check to see if an explicit version has been provided + _, err := semver.NewVersion(version) + + // Use an explicit version, otherwise search for tags + if err == nil { + vs = []*repo.ChartVersion{{ Metadata: &chart.Metadata{ - Version: t, + Version: version, }, + }} + + } else { + // Retrieve list of tags for repository + ref := fmt.Sprintf("%s/%s", strings.TrimPrefix(d.Repository, fmt.Sprintf("%s://", registry.OCIScheme)), d.Name) + tags, err := r.registryClient.Tags(ref) + if err != nil { + return nil, errors.Wrapf(err, "could not retrieve list of tags for repository %s", d.Repository) + } + + vs = make(repo.ChartVersions, len(tags)) + for ti, t := range tags { + // Mock chart version objects + version := &repo.ChartVersion{ + Metadata: &chart.Metadata{ + Version: t, + }, + } + vs[ti] = version } - vs[ti] = version } } From 9fb7b8808ad5fefcb692359001c9e9fe44b06c81 Mon Sep 17 00:00:00 2001 From: jsolana Date: Wed, 2 Mar 2022 09:59:05 +0100 Subject: [PATCH 2/2] test (issue-10711): Test-style error running make test with golangci-lint version 1.44.2 Signed-off-by: Javier Solana Huertas Signed-off-by: jsolana --- internal/test/test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/test/test.go b/internal/test/test.go index 646037606..e4f7f639a 100644 --- a/internal/test/test.go +++ b/internal/test/test.go @@ -88,7 +88,7 @@ func compare(actual []byte, filename string) error { } expected = normalize(expected) if !bytes.Equal(expected, actual) { - return errors.Errorf("does not match golden file %s\n\nWANT:\n'%s'\n\nGOT:\n'%s'\n", filename, expected, actual) + return errors.Errorf("does not match golden file %s\n\nWANT:\n'%s'\n\nGOT:\n'%s'", filename, expected, actual) } return nil }