From 2e481b6caf8f6a7c60feeb49f19fc26e180a2880 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Sun, 28 Apr 2019 21:56:39 -0400 Subject: [PATCH] fix(helm): update Cobra to latest version The version of Cobra used in dev-v3 is older than the one used for the master branch (helm v2). Although the dev-v3 branch was based on master and therefore had the same Cobra version originally, it was changed a couple of times to choose Cobra tagged versions instead. However, the latest Cobra tagged version is older than the version of Cobra used on the master branch. Therefore, some of the improvements made to Cobra and used by helm v2 are not available to helm v3 currently. This commit brings Cobra to its latest available commit for helm v3. Originally, I thought of selecting the same Cobra version in v3 as for helm v2, but after reviewing the 5 extra commits added to Cobra, I feel it is safe and valuable to bring them in also. Bringing Cobra up-to-date is essential for upcoming work being prepared for dynamic bash-completion; there are bug fixes in Cobra that are necessary for dynamic bash-completion to work properly. Specifically, https://github.com/spf13/cobra/pull/730 which fixes https://github.com/spf13/cobra/issues/694 is essential to avoid the risk of colliding and possibly breaking kubectl dynamic bash-completion once helm v3 has its own dynamic completion. Signed-off-by: Marc Khouzam --- Gopkg.lock | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Gopkg.lock b/Gopkg.lock index 7e4514968..cf47740f7 100644 --- a/Gopkg.lock +++ b/Gopkg.lock @@ -812,8 +812,7 @@ "doc", ] pruneopts = "UT" - revision = "ef82de70bb3f60c65fb8eebacbb2d122ef517385" - version = "v0.0.3" + revision = "67fc4837d267bc9bfd6e47f77783fcc3dffc68de" [[projects]] digest = "1:c1b1102241e7f645bc8e0c22ae352e8f0dc6484b6cb4d132fa9f24174e0119e2"