From 2743020db5e158b95c5a438df3c75cb37621cfbc Mon Sep 17 00:00:00 2001 From: Abhilash Gnan Date: Thu, 9 May 2019 21:23:59 +0200 Subject: [PATCH] fix sort byNamespace test Signed-off-by: Abhilash Gnan --- pkg/releaseutil/sorter_test.go | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/pkg/releaseutil/sorter_test.go b/pkg/releaseutil/sorter_test.go index 4b784c0a0..f480c97e9 100644 --- a/pkg/releaseutil/sorter_test.go +++ b/pkg/releaseutil/sorter_test.go @@ -28,13 +28,13 @@ import ( // note: this test data is shared with filter_test.go. var releases = []*rspb.Release{ - tsRelease("quiet-bear", 2, 2000, rspb.Status_SUPERSEDED), - tsRelease("angry-bird", 4, 3000, rspb.Status_DEPLOYED), - tsRelease("happy-cats", 1, 4000, rspb.Status_DELETED), - tsRelease("vocal-dogs", 3, 6000, rspb.Status_DELETED), + tsRelease("quiet-bear", 2, 2000, rspb.Status_SUPERSEDED, "default"), + tsRelease("angry-bird", 4, 3000, rspb.Status_DEPLOYED, "abc"), + tsRelease("happy-cats", 1, 4000, rspb.Status_DELETED, "def"), + tsRelease("vocal-dogs", 3, 6000, rspb.Status_DELETED, "cde"), } -func tsRelease(name string, vers int32, dur time.Duration, code rspb.Status_Code) *rspb.Release { +func tsRelease(name string, vers int32, dur time.Duration, code rspb.Status_Code, namespace string) *rspb.Release { tmsp := timeconv.Timestamp(time.Now().Add(time.Duration(dur))) info := &rspb.Info{Status: &rspb.Status{Code: code}, LastDeployed: tmsp} return &rspb.Release{ @@ -46,6 +46,7 @@ func tsRelease(name string, vers int32, dur time.Duration, code rspb.Status_Code Name: name, }, }, + Namespace: namespace, } } @@ -96,3 +97,13 @@ func TestSortByChartName(t *testing.T) { return ni < nj }) } + +func TestSortByNamespace(t *testing.T) { + SortByNamespace(releases) + + check(t, "ByNamespace", func(i, j int) bool { + ni := releases[i].Namespace + nj := releases[j].Namespace + return ni < nj + }) +}