Merge pull request #6891 from VilledeMontreal/fix/sortEnv

fix(cli): Sort output of helm env
pull/7202/head
Marc Khouzam 5 years ago committed by GitHub
commit 2457de08ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -19,6 +19,7 @@ package main
import (
"fmt"
"io"
"sort"
"helm.sh/helm/v3/pkg/cli"
@ -55,8 +56,18 @@ type envOptions struct {
}
func (o *envOptions) run(out io.Writer) error {
for k, v := range o.settings.EnvVars() {
fmt.Printf("%s=\"%s\"\n", k, v)
envVars := o.settings.EnvVars()
// Sort the variables by alphabetical order.
// This allows for a constant output across calls to 'helm env'.
var keys []string
for k := range envVars {
keys = append(keys, k)
}
sort.Strings(keys)
for _, k := range keys {
fmt.Printf("%s=\"%s\"\n", k, envVars[k])
}
return nil
}

Loading…
Cancel
Save