From df13268e0bb84ff5219e1a0d708e1f4290455ff3 Mon Sep 17 00:00:00 2001 From: Matt Butcher Date: Tue, 11 Jul 2017 15:47:21 -0600 Subject: [PATCH] fix(CONTRIBUTING): added not about who merges a PR A piece of folk knowledge got lost somewhere along the way: Core contributors should merge their own PRs. --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2c02071ec..29a8193d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -143,6 +143,10 @@ Like any good open source project, we use Pull Requests to track code changes - PRs should stay open until merged or if they have not been active for more than 30 days. This will help keep the PR queue to a manageable size and reduce noise. Should the PR need to stay open (like in the case of a WIP), the `keep open` label can be added. + - If the owner of the PR is listed in `OWNERS`, that user **must** merge their own PRs + or explicitly request another OWNER do that for them. + - If the owner of a PR is _not_ listed in `OWNERS`, any core committer may + merge the PR once it is approved. #### Documentation PRs Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the