From 1ce05ef1a84689f272259d8ffed5f22a8b4ccdac Mon Sep 17 00:00:00 2001 From: ZHAOYAQING <62738635+heijian123@users.noreply.github.com> Date: Fri, 12 Jan 2024 10:37:15 +0800 Subject: [PATCH] Fix after the release rollback fails, the helm still cleans up resources even if no new resources are created. Signed-off-by: ZHAOYAQING <62738635+heijian123@users.noreply.github.com> --- pkg/action/rollback.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/action/rollback.go b/pkg/action/rollback.go index b0be17d13..50e420fbe 100644 --- a/pkg/action/rollback.go +++ b/pkg/action/rollback.go @@ -198,7 +198,7 @@ func (r *Rollback) performRollback(currentRelease, targetRelease *release.Releas targetRelease.Info.Description = msg r.cfg.recordRelease(currentRelease) r.cfg.recordRelease(targetRelease) - if r.CleanupOnFail { + if r.CleanupOnFail && len(results.Created) > 0 { r.cfg.Log("Cleanup on fail set, cleaning up %d resources", len(results.Created)) _, errs := r.cfg.KubeClient.Delete(results.Created) if errs != nil {