From 1b5edb69df3d3a08df77c9902dc17af864ff05d1 Mon Sep 17 00:00:00 2001 From: Simon Croome Date: Mon, 22 Mar 2021 16:42:57 +0000 Subject: [PATCH] Add/update deprecation notices Signed-off-by: Simon Croome (cherry picked from commit c50372a8c1b948f3a140cb6c47e94ba1f0c8438a) --- pkg/action/action.go | 2 +- pkg/chartutil/validate_name.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/action/action.go b/pkg/action/action.go index 79bb4f638..38ba638e4 100644 --- a/pkg/action/action.go +++ b/pkg/action/action.go @@ -65,7 +65,7 @@ var ( // ValidName is a regular expression for resource names. // // DEPRECATED: This will be removed in Helm 4, and is no longer used here. See -// pkg/chartutil.ValidateName for the replacement. +// pkg/lint/rules.validateMetadataNameFunc for the replacement. // // According to the Kubernetes help text, the regular expression it uses is: // diff --git a/pkg/chartutil/validate_name.go b/pkg/chartutil/validate_name.go index 913a477cf..284b8441b 100644 --- a/pkg/chartutil/validate_name.go +++ b/pkg/chartutil/validate_name.go @@ -96,6 +96,9 @@ func ValidateReleaseName(name string) error { // // The Kubernetes documentation is here, though it is not entirely correct: // https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names +// +// Deprecated: remove in Helm 4. Name validation now uses rules defined in +// pkg/lint/rules.validateMetadataNameFunc() func ValidateMetadataName(name string) error { if name == "" || len(name) > maxMetadataNameLen || !validName.MatchString(name) { return errInvalidKubernetesName