From 122502e8406f0381192e41b1071c568e88d8cce3 Mon Sep 17 00:00:00 2001 From: Arash Deshmeh Date: Mon, 19 Feb 2018 12:54:45 -0500 Subject: [PATCH] fix(helm): fix the bug in test code under pkg/tiller that leaks output to stdout during build Signed-off-by: Arash Deshmeh --- pkg/tiller/release_server_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/tiller/release_server_test.go b/pkg/tiller/release_server_test.go index ce95acc8f..d71e34bee 100644 --- a/pkg/tiller/release_server_test.go +++ b/pkg/tiller/release_server_test.go @@ -19,6 +19,7 @@ package tiller import ( "errors" "io" + "io/ioutil" "os" "regexp" "testing" @@ -284,7 +285,7 @@ func releaseWithKeepStub(rlsName string) *release.Release { func MockEnvironment() *environment.Environment { e := environment.New() e.Releases = storage.Init(driver.NewMemory()) - e.KubeClient = &environment.PrintingKubeClient{Out: os.Stdout} + e.KubeClient = &environment.PrintingKubeClient{Out: ioutil.Discard} return e } @@ -305,7 +306,7 @@ func (u *updateFailingKubeClient) Update(namespace string, originalReader, modif func newHookFailingKubeClient() *hookFailingKubeClient { return &hookFailingKubeClient{ - PrintingKubeClient: environment.PrintingKubeClient{Out: os.Stdout}, + PrintingKubeClient: environment.PrintingKubeClient{Out: ioutil.Discard}, } }