From 11b1422071d1a9da6ff473f535c324199ba629c2 Mon Sep 17 00:00:00 2001 From: Luke Addison Date: Sat, 21 Mar 2020 10:04:25 +0000 Subject: [PATCH] Override status on dry run upgrade when a non dry-run upgrade is required Signed-off-by: Luke Addison --- pkg/action/upgrade.go | 3 +++ pkg/release/status.go | 2 ++ 2 files changed, 5 insertions(+) diff --git a/pkg/action/upgrade.go b/pkg/action/upgrade.go index c8e71c6d4..f98a2db98 100644 --- a/pkg/action/upgrade.go +++ b/pkg/action/upgrade.go @@ -242,6 +242,9 @@ func (u *Upgrade) performUpgrade(originalRelease, upgradedRelease *release.Relea }) if u.DryRun { + if len(toBeCreated) > 0 { + upgradedRelease.Info.Status = release.StatusRequiresUpgrade + } u.cfg.Log("dry run for %s", upgradedRelease.Name) if len(u.Description) > 0 { upgradedRelease.Info.Description = u.Description diff --git a/pkg/release/status.go b/pkg/release/status.go index 49b0f1544..fd4153a9d 100644 --- a/pkg/release/status.go +++ b/pkg/release/status.go @@ -39,6 +39,8 @@ const ( StatusPendingUpgrade Status = "pending-upgrade" // StatusPendingRollback indicates that an rollback operation is underway. StatusPendingRollback Status = "pending-rollback" + // StatusRequiresUpgrade indicates an upgrade is required, for example if resources are missing. + StatusRequiresUpgrade Status = "requires-upgrade" ) func (x Status) String() string { return string(x) }