From 071558d69ffbb408dcb56403d387a1aa90a7d3a8 Mon Sep 17 00:00:00 2001
From: Matthieu MOREL <matthieu.morel35@gmail.com>
Date: Sat, 14 Mar 2026 09:32:42 +0100
Subject: [PATCH] chore: fix bool-compare issues from testifylint

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
---
 .golangci.yml                     | 19 +++++++++++++++++++
 internal/chart/v3/chart_test.go   |  4 ++--
 pkg/action/get_values_test.go     |  2 +-
 pkg/action/push_test.go           |  4 ++--
 pkg/action/registry_login_test.go |  4 ++--
 pkg/chart/v2/chart_test.go        |  4 ++--
 6 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 536b4b212..bbd7a18b8 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -32,6 +32,7 @@ linters:
     - revive
     - sloglint
     - staticcheck
+    - testifylint
     - thelper
     - unused
     - usestdlibvars
@@ -92,6 +93,24 @@ linters:
                   - helpers
                   - models
 
+    testifylint:
+      disable:
+        - empty
+        - encoded-compare
+        - equal-values
+        - error-is-as
+        - error-nil
+        - expected-actual
+        - float-compare
+        - go-require
+        - len
+        - nil-compare
+        - require-error
+        - suite-dont-use-pkg
+        - suite-extra-assert-call
+      # Intentionally enable all testifylint rules so new checks are adopted automatically.
+      enable-all: true
+
 run:
   timeout: 10m
 
diff --git a/internal/chart/v3/chart_test.go b/internal/chart/v3/chart_test.go
index 07cbf4b39..5f6ca548d 100644
--- a/internal/chart/v3/chart_test.go
+++ b/internal/chart/v3/chart_test.go
@@ -124,8 +124,8 @@ func TestIsRoot(t *testing.T) {
 
 	is := assert.New(t)
 
-	is.Equal(false, chrt1.IsRoot())
-	is.Equal(true, chrt2.IsRoot())
+	is.False(chrt1.IsRoot())
+	is.True(chrt2.IsRoot())
 }
 
 func TestChartPath(t *testing.T) {
diff --git a/pkg/action/get_values_test.go b/pkg/action/get_values_test.go
index 01ee4c3f1..c4cbdf2d5 100644
--- a/pkg/action/get_values_test.go
+++ b/pkg/action/get_values_test.go
@@ -37,7 +37,7 @@ func TestNewGetValues(t *testing.T) {
 	assert.NotNil(t, client)
 	assert.Equal(t, cfg, client.cfg)
 	assert.Equal(t, 0, client.Version)
-	assert.Equal(t, false, client.AllValues)
+	assert.False(t, client.AllValues)
 }
 
 func TestGetValues_Run_UserConfigOnly(t *testing.T) {
diff --git a/pkg/action/push_test.go b/pkg/action/push_test.go
index 35c6f3efc..125799252 100644
--- a/pkg/action/push_test.go
+++ b/pkg/action/push_test.go
@@ -47,14 +47,14 @@ func TestNewPushWithInsecureSkipTLSVerify(t *testing.T) {
 	client := NewPushWithOpts(WithInsecureSkipTLSVerify(true))
 
 	assert.NotNil(t, client)
-	assert.Equal(t, true, client.insecureSkipTLSVerify)
+	assert.True(t, client.insecureSkipTLSVerify)
 }
 
 func TestNewPushWithPlainHTTP(t *testing.T) {
 	client := NewPushWithOpts(WithPlainHTTP(true))
 
 	assert.NotNil(t, client)
-	assert.Equal(t, true, client.plainHTTP)
+	assert.True(t, client.plainHTTP)
 }
 
 func TestNewPushWithPushOptWriter(t *testing.T) {
diff --git a/pkg/action/registry_login_test.go b/pkg/action/registry_login_test.go
index de2450d9d..590673b3a 100644
--- a/pkg/action/registry_login_test.go
+++ b/pkg/action/registry_login_test.go
@@ -48,7 +48,7 @@ func TestWithInsecure(t *testing.T) {
 	opt := WithInsecure(true)
 
 	assert.Nil(t, opt(client))
-	assert.Equal(t, true, client.insecure)
+	assert.True(t, client.insecure)
 }
 
 func TestWithKeyFile(t *testing.T) {
@@ -80,5 +80,5 @@ func TestWithPlainHTTPLogin(t *testing.T) {
 	opt := WithPlainHTTPLogin(true)
 
 	assert.Nil(t, opt(client))
-	assert.Equal(t, true, client.plainHTTP)
+	assert.True(t, client.plainHTTP)
 }
diff --git a/pkg/chart/v2/chart_test.go b/pkg/chart/v2/chart_test.go
index d0837eb16..d44e7251b 100644
--- a/pkg/chart/v2/chart_test.go
+++ b/pkg/chart/v2/chart_test.go
@@ -124,8 +124,8 @@ func TestIsRoot(t *testing.T) {
 
 	is := assert.New(t)
 
-	is.Equal(false, chrt1.IsRoot())
-	is.Equal(true, chrt2.IsRoot())
+	is.False(chrt1.IsRoot())
+	is.True(chrt2.IsRoot())
 }
 
 func TestChartPath(t *testing.T) {