From 06cc96fd66bf6541c8d0c62060acdd64fc25f1ad Mon Sep 17 00:00:00 2001
From: Michal Cwienczek <michael.cwienczek@gmail.com>
Date: Tue, 3 Oct 2017 20:25:58 +0200
Subject: [PATCH] Added tests for query string repo

---
 pkg/downloader/chart_downloader_test.go          |  1 +
 .../cache/testing-querystring-index.yaml         | 16 ++++++++++++++++
 .../helmhome/repository/repositories.yaml        |  2 ++
 3 files changed, 19 insertions(+)
 create mode 100644 pkg/downloader/testdata/helmhome/repository/cache/testing-querystring-index.yaml

diff --git a/pkg/downloader/chart_downloader_test.go b/pkg/downloader/chart_downloader_test.go
index 4049b7979..73f9191c9 100644
--- a/pkg/downloader/chart_downloader_test.go
+++ b/pkg/downloader/chart_downloader_test.go
@@ -43,6 +43,7 @@ func TestResolveChartRef(t *testing.T) {
 		{name: "reference, testing repo", ref: "testing/alpine", expect: "http://example.com/alpine-1.2.3.tgz"},
 		{name: "reference, version, testing repo", ref: "testing/alpine", version: "0.2.0", expect: "http://example.com/alpine-0.2.0.tgz"},
 		{name: "reference, version, malformed repo", ref: "malformed/alpine", version: "1.2.3", expect: "http://dl.example.com/alpine-1.2.3.tgz"},
+		{name: "reference, querystring repo", ref: "testing-querystring/alpine", expect: "http://example.com/alpine-1.2.3.tgz?key=value"},
 		{name: "full URL, HTTPS, irrelevant version", ref: "https://example.com/foo-1.2.3.tgz", version: "0.1.0", expect: "https://example.com/foo-1.2.3.tgz", fail: true},
 		{name: "full URL, file", ref: "file:///foo-1.2.3.tgz", fail: true},
 		{name: "invalid", ref: "invalid-1.2.3", fail: true},
diff --git a/pkg/downloader/testdata/helmhome/repository/cache/testing-querystring-index.yaml b/pkg/downloader/testdata/helmhome/repository/cache/testing-querystring-index.yaml
new file mode 100644
index 000000000..1956e9f83
--- /dev/null
+++ b/pkg/downloader/testdata/helmhome/repository/cache/testing-querystring-index.yaml
@@ -0,0 +1,16 @@
+apiVersion: v1
+entries:
+  alpine:
+    - name: alpine
+      urls:
+        - alpine-1.2.3.tgz
+      checksum: 0e6661f193211d7a5206918d42f5c2a9470b737d
+      home: https://k8s.io/helm
+      sources:
+      - https://github.com/kubernetes/helm
+      version: 1.2.3
+      description: Deploy a basic Alpine Linux pod
+      keywords: []
+      maintainers: []
+      engine: ""
+      icon: ""
diff --git a/pkg/downloader/testdata/helmhome/repository/repositories.yaml b/pkg/downloader/testdata/helmhome/repository/repositories.yaml
index 9b0cfe972..68efb461a 100644
--- a/pkg/downloader/testdata/helmhome/repository/repositories.yaml
+++ b/pkg/downloader/testdata/helmhome/repository/repositories.yaml
@@ -10,3 +10,5 @@ repositories:
     url: "http://example.com/charts"
   - name: malformed
     url: "http://dl.example.com"
+  - name: testing-querystring
+    url: "http://example.com?key=value"
\ No newline at end of file