Update after review

Comments:
- https://github.com/helm/helm/pull/7261#discussion_r373827088
- https://github.com/helm/helm/pull/7261#discussion_r373827250

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
pull/7261/head
Martin Hickey 6 years ago
parent 8394f726db
commit 04514a5448

@ -112,10 +112,4 @@ func TestDependencyBuildCmdWithHelmV2Hash(t *testing.T) {
t.Logf("Output: %s", out)
t.Fatal(err)
}
// Make sure the child chart file got downloaded.
expect := filepath.Join(chartName, "charts/alpine-0.1.0.tgz")
if _, err := os.Stat(expect); err != nil {
t.Fatal(err)
}
}

@ -93,10 +93,10 @@ func (m *Manager) Build() error {
if c.Metadata.APIVersion == chart.APIVersionV1 {
log.Println("warning: a valid Helm v3 hash was not found. Checking against Helm v2 hash...")
if sum, err := resolver.HashV2Req(req); err != nil || sum != lock.Digest {
return errors.New("the lock file is out of sync with the dependencies file. Please update the dependencies")
return errors.New("the lock file (requirements.lock) is out of sync with the dependencies file (requirements.yaml). Please update the dependencies")
}
} else {
return errors.New("the lock file is out of sync with the dependencies file. Please update the dependencies")
return errors.New("the lock file (Chart.lock) is out of sync with the dependencies file (Chart.yaml). Please update the dependencies")
}
}

Loading…
Cancel
Save