diff --git a/pkg/repo/inmem_repo_service.go b/pkg/repo/inmem_repo_service.go index a987dd467..b40368853 100644 --- a/pkg/repo/inmem_repo_service.go +++ b/pkg/repo/inmem_repo_service.go @@ -42,13 +42,13 @@ func NewInmemRepoService() IRepoService { } // List returns the list of all known chart repositories -func (rs *inmemRepoService) List() ([]IRepo, error) { +func (rs *inmemRepoService) List() ([]string, error) { rs.RLock() defer rs.RUnlock() - ret := []IRepo{} + ret := []string{} for _, r := range rs.repositories { - ret = append(ret, r) + ret = append(ret, r.GetName()) } return ret, nil diff --git a/pkg/repo/inmem_repo_service_test.go b/pkg/repo/inmem_repo_service_test.go index 22d8184c8..59c273a2a 100644 --- a/pkg/repo/inmem_repo_service_test.go +++ b/pkg/repo/inmem_repo_service_test.go @@ -32,7 +32,11 @@ func TestService(t *testing.T) { t.Fatalf("unexpected repo count; want: %d, have %d.", 1, len(repos)) } - tr := repos[0] + tr, err := rs.Get(repos[0]) + if err != nil { + t.Fatalf("cannot get repo named %s: %s", repos[0], err) + } + if err := validateRepo(tr, GCSPublicRepoName, GCSPublicRepoURL, "", GCSRepoFormat, GCSRepoType); err != nil { t.Fatal(err) } diff --git a/pkg/repo/types.go b/pkg/repo/types.go index fa13bf474..d58e482db 100644 --- a/pkg/repo/types.go +++ b/pkg/repo/types.go @@ -118,7 +118,7 @@ type IStorageRepo interface { // repository based operations, such as search and chart reference resolution. type IRepoService interface { // List returns the list of all known chart repositories - List() ([]IRepo, error) + List() ([]string, error) // Create adds a known repository to the list Create(repository IRepo) error // Get returns the repository with the given name