|
|
|
/*
|
|
|
|
Copyright 2016 The Kubernetes Authors All rights reserved.
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package rules // import "k8s.io/helm/pkg/lint/rules"
|
|
|
|
|
|
|
|
import (
|
|
|
|
"errors"
|
|
|
|
"fmt"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"strings"
|
|
|
|
|
|
|
|
"github.com/Masterminds/semver"
|
|
|
|
|
|
|
|
"github.com/asaskevich/govalidator"
|
|
|
|
"k8s.io/helm/pkg/chartutil"
|
|
|
|
"k8s.io/helm/pkg/lint/support"
|
|
|
|
"k8s.io/helm/pkg/proto/hapi/chart"
|
|
|
|
)
|
|
|
|
|
|
|
|
// Chartfile runs a set of linter rules related to Chart.yaml file
|
|
|
|
func Chartfile(linter *support.Linter) {
|
|
|
|
chartFileName := "Chart.yaml"
|
|
|
|
chartPath := filepath.Join(linter.ChartDir, chartFileName)
|
|
|
|
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartYamlNotDirectory(chartPath))
|
|
|
|
|
|
|
|
chartFile, err := chartutil.LoadChartfile(chartPath)
|
|
|
|
validChartFile := linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartYamlFormat(err))
|
|
|
|
|
|
|
|
// Guard clause. Following linter rules require a parseable ChartFile
|
|
|
|
if !validChartFile {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartName(chartFile))
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartNameDirMatch(linter.ChartDir, chartFile))
|
|
|
|
|
|
|
|
// Chart metadata
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartVersion(chartFile))
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartEngine(chartFile))
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartMaintainer(chartFile))
|
|
|
|
linter.RunLinterRule(support.ErrorSev, chartFileName, validateChartSources(chartFile))
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartYamlNotDirectory(chartPath string) error {
|
|
|
|
fi, err := os.Stat(chartPath)
|
|
|
|
|
|
|
|
if err == nil && fi.IsDir() {
|
|
|
|
return errors.New("should be a file, not a directory")
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartYamlFormat(chartFileError error) error {
|
|
|
|
if chartFileError != nil {
|
|
|
|
return fmt.Errorf("unable to parse YAML\n\t%s", chartFileError.Error())
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartName(cf *chart.Metadata) error {
|
|
|
|
if cf.Name == "" {
|
|
|
|
return errors.New("name is required")
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartNameDirMatch(chartDir string, cf *chart.Metadata) error {
|
|
|
|
if cf.Name != filepath.Base(chartDir) {
|
|
|
|
return fmt.Errorf("directory name (%s) and chart name (%s) must be the same", filepath.Base(chartDir), cf.Name)
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartVersion(cf *chart.Metadata) error {
|
|
|
|
if cf.Version == "" {
|
|
|
|
return errors.New("version is required")
|
|
|
|
}
|
|
|
|
|
|
|
|
version, err := semver.NewVersion(cf.Version)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("version '%s' is not a valid SemVer", cf.Version)
|
|
|
|
}
|
|
|
|
|
|
|
|
c, err := semver.NewConstraint("> 0")
|
|
|
|
valid, msg := c.Validate(version)
|
|
|
|
|
|
|
|
if !valid && len(msg) > 0 {
|
|
|
|
return fmt.Errorf("version %v", msg[0])
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartEngine(cf *chart.Metadata) error {
|
|
|
|
if cf.Engine == "" {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
keys := make([]string, 0, len(chart.Metadata_Engine_value))
|
|
|
|
for engine := range chart.Metadata_Engine_value {
|
|
|
|
str := strings.ToLower(engine)
|
|
|
|
|
|
|
|
if str == "unknown" {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if str == cf.Engine {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
keys = append(keys, str)
|
|
|
|
}
|
|
|
|
|
|
|
|
return fmt.Errorf("engine '%v' not valid. Valid options are %v", cf.Engine, keys)
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartMaintainer(cf *chart.Metadata) error {
|
|
|
|
for _, maintainer := range cf.Maintainers {
|
|
|
|
if maintainer.Name == "" {
|
|
|
|
return errors.New("each maintainer requires a name")
|
|
|
|
} else if maintainer.Email != "" && !govalidator.IsEmail(maintainer.Email) {
|
|
|
|
return fmt.Errorf("invalid email '%s' for maintainer '%s'", maintainer.Email, maintainer.Name)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartSources(cf *chart.Metadata) error {
|
|
|
|
for _, source := range cf.Sources {
|
|
|
|
if source == "" || !govalidator.IsRequestURL(source) {
|
|
|
|
return fmt.Errorf("invalid source URL '%s'", source)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func validateChartHome(cf *chart.Metadata) error {
|
|
|
|
if cf.Home != "" && !govalidator.IsRequestURL(cf.Home) {
|
|
|
|
return fmt.Errorf("invalid home URL '%s'", cf.Home)
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|