From 11d58c0f5977eda5cb3789933622014953fefe26 Mon Sep 17 00:00:00 2001 From: Konrad Rydzak <50720637+konradrydzak@users.noreply.github.com> Date: Wed, 19 Apr 2023 21:32:21 +0200 Subject: [PATCH] fix calculateColor function Fix sorting co2Scale to not be in place, change finding scaleIndex to be equal to closestNum (not greater than). --- .../3-background-tasks-and-performance/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/5-browser-extension/3-background-tasks-and-performance/README.md b/5-browser-extension/3-background-tasks-and-performance/README.md index 7794f1c4..a7aec9dc 100644 --- a/5-browser-extension/3-background-tasks-and-performance/README.md +++ b/5-browser-extension/3-background-tasks-and-performance/README.md @@ -65,11 +65,11 @@ function calculateColor(value) { let co2Scale = [0, 150, 600, 750, 800]; let colors = ['#2AA364', '#F5EB4D', '#9E4229', '#381D02', '#381D02']; - let closestNum = co2Scale.sort((a, b) => { + let closestNum = co2Scale.slice().sort((a, b) => { return Math.abs(a - value) - Math.abs(b - value); })[0]; console.log(value + ' is closest to ' + closestNum); - let num = (element) => element > closestNum; + let num = (element) => element === closestNum; let scaleIndex = co2Scale.findIndex(num); let closestColor = colors[scaleIndex];