From c69fb1b55ee1e6afde36462528be7c5b911f4153 Mon Sep 17 00:00:00 2001 From: Drugsosos <44712637+Drugsosos@users.noreply.github.com> Date: Sun, 17 Jul 2022 00:25:24 +0300 Subject: [PATCH] review fixes --- .config.template.toml | 4 ++-- TTS/common.py | 9 ++++++--- TTS/engine_wrapper.py | 6 ++++-- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.config.template.toml b/.config.template.toml index 90096b6..877e45d 100644 --- a/.config.template.toml +++ b/.config.template.toml @@ -16,7 +16,7 @@ subreddit = { optional = false, regex = "[_0-9a-zA-Z]+$", nmin = 3, explanation post_id = { optional = true, default = "", regex = "^((?!://|://)[+a-zA-Z])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } max_comment_length = { default = 500, optional = false, nmin = 10, nmax = 10000, type = "int", explanation = "max number of characters a comment can have. default is 500", example = 500, oob_error = "the max comment length should be between 10 and 10000" } post_lang = { default = "", optional = true, explanation = "The language you would like to translate to.", example = "es-cr" } -min_comments = { default = 20, optional = false, nmin = 1, type = "int", explanation = "The minimum number of comments a post should have to be included. default is 20", example = 29, oob_error = "the minimum number of comments should be between 1 and 999999" } +min_comments = { default = 20, optional = false, nmin = 15, type = "int", explanation = "The minimum number of comments a post should have to be included. default is 20", example = 29, oob_error = "the minimum number of comments should be between 1 and 999999" } [settings] allow_nsfw = { optional = false, type = "bool", default = false, example = false, options = [true, false, @@ -25,7 +25,7 @@ theme = { optional = false, default = "dark", example = "light", options = ["dar "light", ], explanation = "sets the Reddit theme, either LIGHT or DARK" } times_to_run = { optional = false, default = 1, example = 2, explanation = "used if you want to run multiple times. set to an int e.g. 4 or 29 or 1", type = "int", nmin = 1, oob_error = "It's very hard to run something less than once." } -opacity = { optional = false, default = 90, example = 80, explanation = "Sets the opacity (in percents) of the comments when overlayed over the background", type = "int", nmin = 10, nmax = 100, oob_error = "The opacity HAS to be between 10 and 100 percents", input_error = "The opacity HAS to be a number between 10 and 100" } +opacity = { optional = false, default = 0.9, example = 0.8, explanation = "Sets the opacity of the comments when overlayed over the background", type = "float", nmin = 0, nmax = 1, oob_error = "The opacity HAS to be between 0 and 1", input_error = "The opacity HAS to be a decimal number between 0 and 1" } storymode = { optional = true, type = "bool", default = false, example = false, options = [true, false, ], explanation = "not yet implemented" } diff --git a/TTS/common.py b/TTS/common.py index 9f71090..5e6f629 100644 --- a/TTS/common.py +++ b/TTS/common.py @@ -124,11 +124,14 @@ def audio_length( Returns: length in seconds as an int """ - from mutagen.mp3 import MP3 + from moviepy.editor import AudioFileClip try: - audio = MP3(path) - return audio.info.length + # please use something else here in the future + audio_clip = AudioFileClip(path) + audio_duration = audio_clip.duration + audio_clip.close() + return audio_duration except Exception as e: import logging diff --git a/TTS/engine_wrapper.py b/TTS/engine_wrapper.py index 5534269..2a0986b 100644 --- a/TTS/engine_wrapper.py +++ b/TTS/engine_wrapper.py @@ -72,8 +72,10 @@ class TTSEngine: sync_tasks_primary = [ self.call_tts(str(idx), comment['comment_body']) - for idx, comment in track(enumerate(self.reddit_object['comments']), description='Saving...') - # Crunch, there will be fix in async TTS api + for idx, comment in track( + enumerate(self.reddit_object['comments']), + description='Saving...') + # Crunch, there will be fix in async TTS api, maybe if self.__total_length + self.__total_length * 0.05 < self.max_length ]