From 64581afd8c78bfef4525ca2990c22d69367ae57c Mon Sep 17 00:00:00 2001 From: gerzees Date: Wed, 3 Jun 2020 09:21:38 +0900 Subject: [PATCH] 1. Extract method 2. drawFunctionPatterns in Qrcode 3. Method drawFunctionPatterns was long --- .../src/main/java/io/nayuki/qrcodegen/QrCode.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/java/src/main/java/io/nayuki/qrcodegen/QrCode.java b/java/src/main/java/io/nayuki/qrcodegen/QrCode.java index 1951bb1..162aaf0 100644 --- a/java/src/main/java/io/nayuki/qrcodegen/QrCode.java +++ b/java/src/main/java/io/nayuki/qrcodegen/QrCode.java @@ -412,7 +412,16 @@ public final class QrCode { drawFinderPattern(size - 1 - FINDER_SIZE, FINDER_SIZE); drawFinderPattern(FINDER_SIZE, size - 1 - FINDER_SIZE); - // Draw numerous alignment patterns + drawAlignmentsPatterns(); + + // Draw configuration data + drawFormatBits(0); // Dummy mask value; overwritten later in the constructor + drawVersion(); + } + + + // Draw numerous alignment patterns + private void drawAlignmentsPatterns() { int[] alignPatPos = getAlignmentPatternPositions(); int numAlign = alignPatPos.length; for (int i = 0; i < numAlign; i++) { @@ -425,10 +434,6 @@ public final class QrCode { drawAlignmentPattern(alignPatPos[i], alignPatPos[j]); } } - - // Draw configuration data - drawFormatBits(0); // Dummy mask value; overwritten later in the constructor - drawVersion(); }