From 13d0883507be9fa915b80c9ca2ff5d7cda4511b4 Mon Sep 17 00:00:00 2001 From: OpenIM-Gordon <46924906+FGadvancer@users.noreply.github.com> Date: Wed, 6 Mar 2024 20:53:36 +0800 Subject: [PATCH] fix: remove unnecessary error handling to avoid sending nil resp. (#2010) * fix: remove unnecessary error handling to avoid sending failed notifications. * fix: remove unnecessary error handling to avoid sending nil resp. --- internal/rpc/group/group.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/rpc/group/group.go b/internal/rpc/group/group.go index d44c79b45..4be8fab0c 100644 --- a/internal/rpc/group/group.go +++ b/internal/rpc/group/group.go @@ -757,7 +757,7 @@ func (s *groupServer) GroupApplicationResponse(ctx context.Context, req *pbgroup return nil, errs.ErrGroupRequestHandled.Wrap("group request already processed") } var inGroup bool - if _, takeErr := s.db.TakeGroupMember(ctx, req.GroupID, req.FromUserID); takeErr == nil { + if _, err := s.db.TakeGroupMember(ctx, req.GroupID, req.FromUserID); err == nil { inGroup = true // Already in group } else if !s.IsNotFound(err) { return nil, err