From 7065b5f81b7c8308aba8b26b1e34de9457157842 Mon Sep 17 00:00:00 2001 From: icey-yu <1186114839@qq.com> Date: Fri, 7 Jun 2024 19:14:08 +0800 Subject: [PATCH] fix: change fcm config path --- internal/push/offlinepush/fcm/push.go | 5 ++--- internal/push/offlinepush/offlinepusher.go | 4 ++-- internal/push/push.go | 4 ++-- pkg/common/cmd/push.go | 2 +- pkg/common/cmd/root.go | 7 ++++--- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/internal/push/offlinepush/fcm/push.go b/internal/push/offlinepush/fcm/push.go index 38a9c94d5..06eef0187 100644 --- a/internal/push/offlinepush/fcm/push.go +++ b/internal/push/offlinepush/fcm/push.go @@ -40,13 +40,12 @@ type Fcm struct { // NewClient initializes a new FCM client using the Firebase Admin SDK. // It requires the FCM service account credentials file located within the project's configuration directory. -func NewClient(pushConf *config.Push, cache cache.ThirdCache, fcmPath string) (*Fcm, error) { +func NewClient(pushConf *config.Push, cache cache.ThirdCache, fcmConfigPath string) (*Fcm, error) { //projectRoot, err := config.GetProjectRoot() //if err != nil { // return nil, err //} - projectRoot := fcmPath - credentialsFilePath := filepath.Join(projectRoot, pushConf.FCM.ServiceAccount) + credentialsFilePath := filepath.Join(fcmConfigPath, pushConf.FCM.ServiceAccount) opt := option.WithCredentialsFile(credentialsFilePath) fcmApp, err := firebase.NewApp(context.Background(), nil, opt) if err != nil { diff --git a/internal/push/offlinepush/offlinepusher.go b/internal/push/offlinepush/offlinepusher.go index a1e9b8809..9aa6625de 100644 --- a/internal/push/offlinepush/offlinepusher.go +++ b/internal/push/offlinepush/offlinepusher.go @@ -36,13 +36,13 @@ type OfflinePusher interface { Push(ctx context.Context, userIDs []string, title, content string, opts *options.Opts) error } -func NewOfflinePusher(pushConf *config.Push, cache cache.ThirdCache, fcmPath string) (OfflinePusher, error) { +func NewOfflinePusher(pushConf *config.Push, cache cache.ThirdCache, fcmConfigPath string) (OfflinePusher, error) { var offlinePusher OfflinePusher switch pushConf.Enable { case geTUI: offlinePusher = getui.NewClient(pushConf, cache) case firebase: - return fcm.NewClient(pushConf, cache, fcmPath) + return fcm.NewClient(pushConf, cache, fcmConfigPath) case jPush: offlinePusher = jpush.NewClient(pushConf) default: diff --git a/internal/push/push.go b/internal/push/push.go index 2ecc6da20..1a04bbea2 100644 --- a/internal/push/push.go +++ b/internal/push/push.go @@ -29,7 +29,7 @@ type Config struct { WebhooksConfig config.Webhooks LocalCacheConfig config.LocalCache Discovery config.Discovery - FcmPath string + FcmConfigPath string } func (p pushServer) PushMsg(ctx context.Context, req *pbpush.PushMsgReq) (*pbpush.PushMsgResp, error) { @@ -51,7 +51,7 @@ func Start(ctx context.Context, config *Config, client discovery.SvcDiscoveryReg return err } cacheModel := redis.NewThirdCache(rdb) - offlinePusher, err := offlinepush.NewOfflinePusher(&config.RpcConfig, cacheModel, config.FcmPath) + offlinePusher, err := offlinepush.NewOfflinePusher(&config.RpcConfig, cacheModel, config.FcmConfigPath) if err != nil { return err } diff --git a/pkg/common/cmd/push.go b/pkg/common/cmd/push.go index 44c3e5826..0594b4100 100644 --- a/pkg/common/cmd/push.go +++ b/pkg/common/cmd/push.go @@ -44,7 +44,7 @@ func NewPushRpcCmd() *PushRpcCmd { LocalCacheConfigFileName: &pushConfig.LocalCacheConfig, DiscoveryConfigFilename: &pushConfig.Discovery, } - ret.pushConfig.FcmPath = ret.FcmPath() + ret.pushConfig.FcmPath = ret.ConfigPath() ret.RootCmd = NewRootCmd(program.GetProcessName(), WithConfigMap(ret.configMap)) ret.ctx = context.WithValue(context.Background(), "version", config.Version) ret.Command.RunE = func(cmd *cobra.Command, args []string) error { diff --git a/pkg/common/cmd/root.go b/pkg/common/cmd/root.go index 65031c5ff..08bb6d064 100644 --- a/pkg/common/cmd/root.go +++ b/pkg/common/cmd/root.go @@ -31,11 +31,11 @@ type RootCmd struct { prometheusPort int log config.Log index int - fcmPath string + configPath string } -func (r *RootCmd) FcmPath() string { - return r.fcmPath +func (r *RootCmd) ConfigPath() string { + return r.configPath } func (r *RootCmd) Index() int { @@ -158,6 +158,7 @@ func (r *RootCmd) getFlag(cmd *cobra.Command) (string, int, error) { if err != nil { return "", 0, errs.Wrap(err) } + r.configPath = configDirectory index, err := cmd.Flags().GetInt(FlagTransferIndex) if err != nil { return "", 0, errs.Wrap(err)