From f96f6cae9105e06672cc0f94c2797dbdc3413608 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Thu, 29 Nov 2018 13:49:37 +0100
Subject: [PATCH] Updated legend

---
 app/src/main/res/layout/fragment_legend.xml | 54 ++++++++++++++++++---
 app/src/main/res/values/strings.xml         |  4 +-
 2 files changed, 50 insertions(+), 8 deletions(-)

diff --git a/app/src/main/res/layout/fragment_legend.xml b/app/src/main/res/layout/fragment_legend.xml
index 2bb1cbcd98..41c890eefd 100644
--- a/app/src/main/res/layout/fragment_legend.xml
+++ b/app/src/main/res/layout/fragment_legend.xml
@@ -209,7 +209,7 @@
             app:layout_constraintTop_toTopOf="@id/ivContacts" />
 
         <ImageView
-            android:id="@+id/ivImage"
+            android:id="@+id/ivExternalImage"
             android:layout_width="24dp"
             android:layout_height="24dp"
             android:layout_marginTop="12dp"
@@ -218,15 +218,55 @@
             app:layout_constraintTop_toBottomOf="@id/ivContacts" />
 
         <TextView
-            android:id="@+id/tvImage"
+            android:id="@+id/tvExternalImage"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_marginStart="18dp"
-            android:text="@string/title_legend_image"
+            android:text="@string/title_legend_external_image"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
-            app:layout_constraintBottom_toBottomOf="@id/ivImage"
-            app:layout_constraintStart_toEndOf="@id/ivImage"
-            app:layout_constraintTop_toTopOf="@id/ivImage" />
+            app:layout_constraintBottom_toBottomOf="@id/ivExternalImage"
+            app:layout_constraintStart_toEndOf="@id/ivExternalImage"
+            app:layout_constraintTop_toTopOf="@id/ivExternalImage" />
+
+        <ImageView
+            android:id="@+id/ivEmbeddedImage"
+            android:layout_width="24dp"
+            android:layout_height="24dp"
+            android:layout_marginTop="12dp"
+            android:src="@drawable/baseline_photo_library_24"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/ivExternalImage" />
+
+        <TextView
+            android:id="@+id/tvEmbeddedImage"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="18dp"
+            android:text="@string/title_legend_embedded_image"
+            android:textAppearance="@style/TextAppearance.AppCompat.Medium"
+            app:layout_constraintBottom_toBottomOf="@id/ivEmbeddedImage"
+            app:layout_constraintStart_toEndOf="@id/ivEmbeddedImage"
+            app:layout_constraintTop_toTopOf="@id/ivEmbeddedImage" />
+
+        <ImageView
+            android:id="@+id/ivBrokenImage"
+            android:layout_width="24dp"
+            android:layout_height="24dp"
+            android:layout_marginTop="12dp"
+            android:src="@drawable/baseline_broken_image_24"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/ivEmbeddedImage" />
+
+        <TextView
+            android:id="@+id/tvBrokenImage"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="18dp"
+            android:text="@string/title_legend_broken_image"
+            android:textAppearance="@style/TextAppearance.AppCompat.Medium"
+            app:layout_constraintBottom_toBottomOf="@id/ivBrokenImage"
+            app:layout_constraintStart_toEndOf="@id/ivBrokenImage"
+            app:layout_constraintTop_toTopOf="@id/ivBrokenImage" />
 
         <ImageView
             android:id="@+id/ivSynchronize"
@@ -235,7 +275,7 @@
             android:layout_marginTop="12dp"
             android:src="@drawable/baseline_sync_24"
             app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/ivImage" />
+            app:layout_constraintTop_toBottomOf="@id/ivBrokenImage" />
 
         <TextView
             android:id="@+id/tvSynchronize"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 2a64caf5a3..3c2584f258 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -311,7 +311,9 @@
     <string name="title_legend_cc">CC/BCC</string>
     <string name="title_legend_attachment">Attachment</string>
     <string name="title_legend_contacts">Contacts</string>
-    <string name="title_legend_image">Image placeholder</string>
+    <string name="title_legend_external_image">External image placeholder</string>
+    <string name="title_legend_embedded_image">Embedded image placeholder</string>
+    <string name="title_legend_broken_image">Broken image</string>
     <string name="title_legend_synchronize_on">Synchronize on</string>
     <string name="title_legend_synchronize_off">Synchronize off</string>
     <string name="title_legend_primary">Primary/starred</string>