From e34421f1ff8e91d8fe8caaab6c48eb93cd1fc6db Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Sun, 19 Jul 2020 11:22:46 +0200
Subject: [PATCH] Small layout improvement

---
 .../eu/faircode/email/FragmentOptionsPrivacy.java  |  7 ++++---
 .../main/res/layout/fragment_options_privacy.xml   | 14 +++++++-------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/FragmentOptionsPrivacy.java b/app/src/main/java/eu/faircode/email/FragmentOptionsPrivacy.java
index 5f3cb8c535..45deaa6dca 100644
--- a/app/src/main/java/eu/faircode/email/FragmentOptionsPrivacy.java
+++ b/app/src/main/java/eu/faircode/email/FragmentOptionsPrivacy.java
@@ -42,6 +42,7 @@ import android.widget.AdapterView;
 import android.widget.Button;
 import android.widget.CompoundButton;
 import android.widget.EditText;
+import android.widget.ImageButton;
 import android.widget.Spinner;
 import android.widget.TextView;
 import android.widget.Toast;
@@ -67,7 +68,7 @@ public class FragmentOptionsPrivacy extends FragmentBase implements SharedPrefer
     private SwitchCompat swDisplayHidden;
     private SwitchCompat swSecure;
     private SwitchCompat swSafeBrowsing;
-    private Button btnSafeBrowsing;
+    private ImageButton ibSafeBrowsing;
 
     private Group grpSafeBrowsing;
 
@@ -101,7 +102,7 @@ public class FragmentOptionsPrivacy extends FragmentBase implements SharedPrefer
         swDisplayHidden = view.findViewById(R.id.swDisplayHidden);
         swSecure = view.findViewById(R.id.swSecure);
         swSafeBrowsing = view.findViewById(R.id.swSafeBrowsing);
-        btnSafeBrowsing = view.findViewById(R.id.btnSafeBrowsing);
+        ibSafeBrowsing = view.findViewById(R.id.ibSafeBrowsing);
 
         grpSafeBrowsing = view.findViewById(R.id.grpSafeBrowsing);
 
@@ -227,7 +228,7 @@ public class FragmentOptionsPrivacy extends FragmentBase implements SharedPrefer
             }
         });
 
-        btnSafeBrowsing.setOnClickListener(new View.OnClickListener() {
+        ibSafeBrowsing.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
                 Helper.view(getContext(), Uri.parse("https://developers.google.com/safe-browsing"), true);
diff --git a/app/src/main/res/layout/fragment_options_privacy.xml b/app/src/main/res/layout/fragment_options_privacy.xml
index ca9fb70245..b8424ce170 100644
--- a/app/src/main/res/layout/fragment_options_privacy.xml
+++ b/app/src/main/res/layout/fragment_options_privacy.xml
@@ -275,20 +275,20 @@
             app:layout_constraintTop_toBottomOf="@id/tvSecureHint"
             app:switchPadding="12dp" />
 
-        <Button
-            android:id="@+id/btnSafeBrowsing"
-            style="?android:attr/buttonStyleSmall"
+        <ImageButton
+            android:id="@+id/ibSafeBrowsing"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="6dp"
-            android:text="@string/title_info"
+            android:contentDescription="@string/title_info"
+            android:tooltipText="@string/title_info"
             app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/swSafeBrowsing" />
+            app:layout_constraintTop_toBottomOf="@id/swSafeBrowsing"
+            app:srcCompat="@drawable/baseline_info_24" />
 
         <androidx.constraintlayout.widget.Group
             android:id="@+id/grpSafeBrowsing"
             android:layout_width="0dp"
             android:layout_height="0dp"
-            app:constraint_referenced_ids="swSafeBrowsing,btnSafeBrowsing" />
+            app:constraint_referenced_ids="swSafeBrowsing,ibSafeBrowsing" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 </eu.faircode.email.ScrollViewEx>