From ce88d04a0ff8f709a51bea12472ed1528224760f Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Sat, 1 Dec 2018 10:47:08 +0100
Subject: [PATCH] Always report unexpected errors

---
 .../java/eu/faircode/email/ActivityView.java  | 11 +++++++-
 .../eu/faircode/email/AdapterAttachment.java  | 10 ++++++++
 .../eu/faircode/email/AdapterMessage.java     | 25 +++++++++++++++++++
 .../eu/faircode/email/AdapterOperation.java   |  5 ++++
 .../eu/faircode/email/FragmentAccount.java    | 15 +++++++++++
 .../eu/faircode/email/FragmentAnswer.java     |  5 ++++
 .../eu/faircode/email/FragmentCompose.java    |  5 ++++
 .../eu/faircode/email/FragmentFolder.java     |  5 ++++
 .../eu/faircode/email/FragmentIdentity.java   | 20 +++++++++++++++
 .../eu/faircode/email/FragmentMessages.java   | 10 ++++++++
 .../eu/faircode/email/FragmentOptions.java    |  5 ++++
 11 files changed, 115 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/eu/faircode/email/ActivityView.java b/app/src/main/java/eu/faircode/email/ActivityView.java
index e2946fe409..751585b197 100644
--- a/app/src/main/java/eu/faircode/email/ActivityView.java
+++ b/app/src/main/java/eu/faircode/email/ActivityView.java
@@ -578,6 +578,11 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB
                                     .putExtra("id", id));
 
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(ActivityView.this, ex);
+            }
         }.load(this, new Bundle());
     }
 
@@ -741,6 +746,11 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB
                                 .putExtra("account", account)
                                 .putExtra("folder", folder));
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(ActivityView.this, ex);
+            }
         }.load(this, args);
     }
 
@@ -1379,7 +1389,6 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB
 
                         @Override
                         protected void onException(Bundle args, Throwable ex) {
-                            Log.e(Helper.TAG, ex + "\n" + Log.getStackTraceString(ex));
                             Helper.unexpectedError(ActivityView.this, ex);
                         }
                     }.load(this, args);
diff --git a/app/src/main/java/eu/faircode/email/AdapterAttachment.java b/app/src/main/java/eu/faircode/email/AdapterAttachment.java
index e5e6cf2860..14be77b562 100644
--- a/app/src/main/java/eu/faircode/email/AdapterAttachment.java
+++ b/app/src/main/java/eu/faircode/email/AdapterAttachment.java
@@ -149,6 +149,11 @@ public class AdapterAttachment extends RecyclerView.Adapter<AdapterAttachment.Vi
                         EntityAttachment.getFile(context, attachment.id).delete();
                         return null;
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(context, ex);
+                    }
                 }.load(context, owner, args);
 
             } else if (view.getId() == R.id.ivSave) {
@@ -256,6 +261,11 @@ public class AdapterAttachment extends RecyclerView.Adapter<AdapterAttachment.Vi
 
                                 return null;
                             }
+
+                            @Override
+                            protected void onException(Bundle args, Throwable ex) {
+                                Helper.unexpectedError(context, ex);
+                            }
                         }.load(context, owner, args);
                     }
                 }
diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index d83dfeb367..f90bd67db8 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -1130,6 +1130,11 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
                     properties.setExpanded(data.message.id, false);
                     notifyDataSetChanged();
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(context, ex);
+                }
             }.load(context, owner, args);
         }
 
@@ -1267,6 +1272,11 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
 
                                             return null;
                                         }
+
+                                        @Override
+                                        protected void onException(Bundle args, Throwable ex) {
+                                            Helper.unexpectedError(context, ex);
+                                        }
                                     }.load(context, owner, args);
                                 }
                             })
@@ -1297,6 +1307,11 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
 
                                                                 return null;
                                                             }
+
+                                                            @Override
+                                                            protected void onException(Bundle args, Throwable ex) {
+                                                                Helper.unexpectedError(context, ex);
+                                                            }
                                                         }.load(context, owner, args);
                                                     }
                                                 }
@@ -1305,6 +1320,11 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
                             })
                             .show();
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(context, ex);
+                }
             }.load(context, owner, args);
         }
 
@@ -1500,6 +1520,11 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
 
                     popupMenu.show();
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(context, ex);
+                }
             }.load(context, owner, args);
         }
 
diff --git a/app/src/main/java/eu/faircode/email/AdapterOperation.java b/app/src/main/java/eu/faircode/email/AdapterOperation.java
index e565c1fd42..84c1adf804 100644
--- a/app/src/main/java/eu/faircode/email/AdapterOperation.java
+++ b/app/src/main/java/eu/faircode/email/AdapterOperation.java
@@ -95,6 +95,11 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
                     EntityOperation.process(context);
                     return null;
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(context, ex);
+                }
             }.load(context, owner, args);
 
             return true;
diff --git a/app/src/main/java/eu/faircode/email/FragmentAccount.java b/app/src/main/java/eu/faircode/email/FragmentAccount.java
index 0cd4816496..4ab814d9bc 100644
--- a/app/src/main/java/eu/faircode/email/FragmentAccount.java
+++ b/app/src/main/java/eu/faircode/email/FragmentAccount.java
@@ -994,6 +994,11 @@ public class FragmentAccount extends FragmentEx {
                             protected void onLoaded(Bundle args, Integer count) {
                                 cbPrimary.setChecked(count == 0);
                             }
+
+                            @Override
+                            protected void onException(Bundle args, Throwable ex) {
+                                Helper.unexpectedError(getContext(), ex);
+                            }
                         }.load(FragmentAccount.this, new Bundle());
                 } else {
                     int provider = savedInstanceState.getInt("provider");
@@ -1030,8 +1035,18 @@ public class FragmentAccount extends FragmentEx {
                             folders = new ArrayList<>();
                         setFolders(folders);
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(getContext(), ex);
+                    }
                 }.load(FragmentAccount.this, args);
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(getContext(), ex);
+            }
         }.load(this, args);
     }
 
diff --git a/app/src/main/java/eu/faircode/email/FragmentAnswer.java b/app/src/main/java/eu/faircode/email/FragmentAnswer.java
index 779e897259..44cfbb56bf 100644
--- a/app/src/main/java/eu/faircode/email/FragmentAnswer.java
+++ b/app/src/main/java/eu/faircode/email/FragmentAnswer.java
@@ -122,6 +122,11 @@ public class FragmentAnswer extends FragmentEx {
                 pbWait.setVisibility(View.GONE);
                 grpReady.setVisibility(View.VISIBLE);
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(getContext(), ex);
+            }
         }.load(this, args);
     }
 
diff --git a/app/src/main/java/eu/faircode/email/FragmentCompose.java b/app/src/main/java/eu/faircode/email/FragmentCompose.java
index ca96c5f393..8438bea035 100644
--- a/app/src/main/java/eu/faircode/email/FragmentCompose.java
+++ b/app/src/main/java/eu/faircode/email/FragmentCompose.java
@@ -1330,6 +1330,11 @@ public class FragmentCompose extends FragmentEx {
                         }
                     });
                 }
+
+                @Override
+                protected void onException(Bundle args, Throwable ex) {
+                    Helper.unexpectedError(getContext(), ex);
+                }
             }.load(FragmentCompose.this, a);
 
             getActivity().invalidateOptionsMenu();
diff --git a/app/src/main/java/eu/faircode/email/FragmentFolder.java b/app/src/main/java/eu/faircode/email/FragmentFolder.java
index 775c462d3a..966c20549e 100644
--- a/app/src/main/java/eu/faircode/email/FragmentFolder.java
+++ b/app/src/main/java/eu/faircode/email/FragmentFolder.java
@@ -366,6 +366,11 @@ public class FragmentFolder extends FragmentEx {
                 btnSave.setEnabled(true);
                 ibDelete.setVisibility(folder == null || !EntityFolder.USER.equals(folder.type) ? View.GONE : View.VISIBLE);
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(getContext(), ex);
+            }
         }.load(this, args);
     }
 }
diff --git a/app/src/main/java/eu/faircode/email/FragmentIdentity.java b/app/src/main/java/eu/faircode/email/FragmentIdentity.java
index f25acf0476..8d752e1adb 100644
--- a/app/src/main/java/eu/faircode/email/FragmentIdentity.java
+++ b/app/src/main/java/eu/faircode/email/FragmentIdentity.java
@@ -644,6 +644,11 @@ public class FragmentIdentity extends FragmentEx {
                             protected void onLoaded(Bundle args, Integer count) {
                                 cbPrimary.setChecked(count == 0);
                             }
+
+                            @Override
+                            protected void onException(Bundle args, Throwable ex) {
+                                Helper.unexpectedError(getContext(), ex);
+                            }
                         }.load(FragmentIdentity.this, new Bundle());
                 } else {
                     tilPassword.getEditText().setText(savedInstanceState.getString("password"));
@@ -737,8 +742,18 @@ public class FragmentIdentity extends FragmentEx {
                             spAccount.setSelection(account);
                         }
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(getContext(), ex);
+                    }
                 }.load(FragmentIdentity.this, args);
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(getContext(), ex);
+            }
         }.load(this, args);
     }
 
@@ -797,6 +812,11 @@ public class FragmentIdentity extends FragmentEx {
                         }
                     }
             }
+
+            @Override
+            protected void onException(Bundle args, Throwable ex) {
+                Helper.unexpectedError(getContext(), ex);
+            }
         }.load(this, args);
     }
 
diff --git a/app/src/main/java/eu/faircode/email/FragmentMessages.java b/app/src/main/java/eu/faircode/email/FragmentMessages.java
index ee5f7e31bc..db63e7f1a2 100644
--- a/app/src/main/java/eu/faircode/email/FragmentMessages.java
+++ b/app/src/main/java/eu/faircode/email/FragmentMessages.java
@@ -650,6 +650,11 @@ public class FragmentMessages extends FragmentEx {
 
                         popupMenu.show();
                     }
+
+                    @Override
+                    protected void onException(Bundle args, Throwable ex) {
+                        Helper.unexpectedError(getContext(), ex);
+                    }
                 }.load(FragmentMessages.this, args);
             }
 
@@ -1135,6 +1140,11 @@ public class FragmentMessages extends FragmentEx {
                             fragmentTransaction.replace(R.id.content_frame, fragment).addToBackStack("search");
                             fragmentTransaction.commit();
                         }
+
+                        @Override
+                        protected void onException(Bundle args, Throwable ex) {
+                            Helper.unexpectedError(getContext(), ex);
+                        }
                     }.load(FragmentMessages.this, args);
                 } else {
                     FragmentTransaction fragmentTransaction = getFragmentManager().beginTransaction();
diff --git a/app/src/main/java/eu/faircode/email/FragmentOptions.java b/app/src/main/java/eu/faircode/email/FragmentOptions.java
index 4e085ece33..01893e169d 100644
--- a/app/src/main/java/eu/faircode/email/FragmentOptions.java
+++ b/app/src/main/java/eu/faircode/email/FragmentOptions.java
@@ -175,6 +175,11 @@ public class FragmentOptions extends FragmentEx implements SharedPreferences.OnS
 
                             return null;
                         }
+
+                        @Override
+                        protected void onException(Bundle args, Throwable ex) {
+                            Helper.unexpectedError(getContext(), ex);
+                        }
                     }.load(FragmentOptions.this, null);
             }
         });