From b787d889de1b8798fb643f3f1edfb5077f8eba33 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Mon, 22 Mar 2021 08:04:52 +0100
Subject: [PATCH] Prevent send/cancel race condition

---
 .../java/eu/faircode/email/AdapterMessage.java |  2 +-
 .../eu/faircode/email/FragmentMessages.java    | 18 +++++++++++++-----
 .../java/eu/faircode/email/ServiceSend.java    |  4 ++++
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index 32af182ad6..a86e424054 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -3054,7 +3054,7 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                 } else if (id == R.id.ibVerify) {
                     onActionDecrypt(message, false);
                 } else if (id == R.id.ibUndo) {
-                    FragmentMessages.onActionUndo(message, context, owner, parentFragment.getParentFragmentManager());
+                    FragmentMessages.onActionUndoSend(message, context, owner, parentFragment.getParentFragmentManager());
                 } else if (id == R.id.ibRule) {
                     onMenuCreateRule(message);
                 } else if (id == R.id.ibUnsubscribe) {
diff --git a/app/src/main/java/eu/faircode/email/FragmentMessages.java b/app/src/main/java/eu/faircode/email/FragmentMessages.java
index 5f07c6defa..33168fbf2b 100644
--- a/app/src/main/java/eu/faircode/email/FragmentMessages.java
+++ b/app/src/main/java/eu/faircode/email/FragmentMessages.java
@@ -2034,7 +2034,7 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
             }
 
             if (EntityFolder.OUTBOX.equals(message.folderType)) {
-                FragmentMessages.onActionUndo(message, getContext(), getViewLifecycleOwner(), getParentFragmentManager());
+                onActionUndoSend(message, getContext(), getViewLifecycleOwner(), getParentFragmentManager());
                 return;
             }
 
@@ -3613,7 +3613,7 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
         }.execute(FragmentMessages.this, args, "messages:delete");
     }
 
-    static void onActionUndo(TupleMessageEx message, final Context context, final LifecycleOwner owner, final FragmentManager manager) {
+    static void onActionUndoSend(TupleMessageEx message, final Context context, final LifecycleOwner owner, final FragmentManager manager) {
         Bundle args = new Bundle();
         args.putLong("id", message.id);
 
@@ -3622,17 +3622,25 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
             protected EntityMessage onExecute(Context context, Bundle args) {
                 long id = args.getLong("id");
 
+                DB db = DB.getInstance(context);
+
+                EntityOperation operation = db.operation().getOperation(message.id, EntityOperation.SEND);
+                if (operation != null)
+                    if ("executing".equals(operation.state)) {
+                        // Trigger update
+                        db.message().setMessageUiBusy(message.id, new Date().getTime());
+                        return null;
+                    } else
+                        db.operation().deleteOperation(operation.id);
+
                 EntityMessage message;
 
-                DB db = DB.getInstance(context);
                 try {
                     db.beginTransaction();
 
                     message = db.message().getMessage(id);
                     if (message == null)
                         return null;
-                    if (message.account == null)
-                        throw new IllegalStateException("Account missing");
 
                     db.folder().setFolderError(message.folder, null);
                     if (message.identity != null)
diff --git a/app/src/main/java/eu/faircode/email/ServiceSend.java b/app/src/main/java/eu/faircode/email/ServiceSend.java
index 3ca9d52ccb..5719b97b03 100644
--- a/app/src/main/java/eu/faircode/email/ServiceSend.java
+++ b/app/src/main/java/eu/faircode/email/ServiceSend.java
@@ -482,6 +482,10 @@ public class ServiceSend extends ServiceBase implements SharedPreferences.OnShar
     private void onSend(EntityMessage message) throws MessagingException, IOException {
         DB db = DB.getInstance(this);
 
+        EntityOperation operation = db.operation().getOperation(message.id, EntityOperation.SEND);
+        if (operation == null)
+            throw new IllegalArgumentException("Send cancelled");
+
         // Mark attempt
         if (message.last_attempt == null) {
             message.last_attempt = new Date().getTime();