From b67e359c6d6ed5648d702d69122f81880808f373 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Fri, 10 Apr 2020 09:02:09 +0200
Subject: [PATCH] Always reset boundary after close

---
 .../email/BoundaryCallbackMessages.java       | 33 +++++++++++--------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/BoundaryCallbackMessages.java b/app/src/main/java/eu/faircode/email/BoundaryCallbackMessages.java
index 4ff3ce6e62..ef74b00f42 100644
--- a/app/src/main/java/eu/faircode/email/BoundaryCallbackMessages.java
+++ b/app/src/main/java/eu/faircode/email/BoundaryCallbackMessages.java
@@ -113,23 +113,26 @@ public class BoundaryCallbackMessages extends PagedList.BoundaryCallback<TupleMe
     @Override
     public void onZeroItemsLoaded() {
         Log.i("Boundary zero loaded");
-        queue_load();
+        queue_load(state);
     }
 
     @Override
     public void onItemAtEndLoaded(@NonNull final TupleMessageEx itemAtEnd) {
         Log.i("Boundary at end");
-        queue_load();
+        queue_load(state);
     }
 
     void retry() {
-        state.reset();
-        queue_load();
+        executor.submit(new Runnable() {
+            @Override
+            public void run() {
+                close(state);
+            }
+        });
+        queue_load(state);
     }
 
-    private void queue_load() {
-        final State state = this.state;
-
+    private void queue_load(final State state) {
         executor.submit(new Runnable() {
             @Override
             public void run() {
@@ -152,8 +155,7 @@ public class BoundaryCallbackMessages extends PagedList.BoundaryCallback<TupleMe
                                 throw ex;
 
                             Log.w("Boundary", ex);
-                            close();
-                            state.reset();
+                            close(state);
 
                             // Retry
                             load_server(state);
@@ -539,32 +541,37 @@ public class BoundaryCallbackMessages extends PagedList.BoundaryCallback<TupleMe
     }
 
     void destroy() {
-        final State state = this.state;
+        final State old = this.state;
+        old.destroyed = true;
+
         this.state = new State();
-        state.destroyed = true;
 
         executor.submit(new Runnable() {
             @Override
             public void run() {
-                close();
+                close(old);
             }
         });
     }
 
-    private void close() {
+    private void close(State state) {
         Log.i("Boundary close");
+
         try {
             if (state.ifolder != null)
                 state.ifolder.close();
         } catch (Throwable ex) {
             Log.e("Boundary", ex);
         }
+
         try {
             if (state.iservice != null)
                 state.iservice.close();
         } catch (Throwable ex) {
             Log.e("Boundary", ex);
         }
+
+        state.reset();
     }
 
     private class State {