From a14bac0e6999e6d93358faa85935565109e81fa6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Peter=20V=C3=A1gner?= <pvagner@pvagner.tk>
Date: Thu, 26 Dec 2019 22:27:06 +0100
Subject: [PATCH] Added contentDescriptions to more image and floating action
 buttons
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Peter Vágner <pvdeejay@gmail.com>
---
 app/src/main/res/layout/fragment_accounts.xml     |  2 ++
 app/src/main/res/layout/fragment_answers.xml      |  1 +
 app/src/main/res/layout/fragment_certificates.xml |  3 ++-
 app/src/main/res/layout/fragment_folders.xml      |  2 ++
 app/src/main/res/layout/fragment_identities.xml   |  1 +
 app/src/main/res/layout/fragment_messages.xml     | 10 ++++++++++
 app/src/main/res/layout/fragment_rules.xml        |  1 +
 app/src/main/res/values/strings.xml               |  6 ++++++
 8 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/fragment_accounts.xml b/app/src/main/res/layout/fragment_accounts.xml
index 43dd883114..900134228e 100644
--- a/app/src/main/res/layout/fragment_accounts.xml
+++ b/app/src/main/res/layout/fragment_accounts.xml
@@ -69,6 +69,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_compose"
+        android:contentDescription="@string/title_compose"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_edit_24" />
 
@@ -80,6 +81,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_add_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_answers.xml b/app/src/main/res/layout/fragment_answers.xml
index 2d58a91034..436287f3cc 100644
--- a/app/src/main/res/layout/fragment_answers.xml
+++ b/app/src/main/res/layout/fragment_answers.xml
@@ -50,6 +50,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_add_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_certificates.xml b/app/src/main/res/layout/fragment_certificates.xml
index a848df64ee..9bd0a1dc8b 100644
--- a/app/src/main/res/layout/fragment_certificates.xml
+++ b/app/src/main/res/layout/fragment_certificates.xml
@@ -47,6 +47,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_add_24" />
-</androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
+</androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_folders.xml b/app/src/main/res/layout/fragment_folders.xml
index 09ec8202fa..cd651bac6d 100644
--- a/app/src/main/res/layout/fragment_folders.xml
+++ b/app/src/main/res/layout/fragment_folders.xml
@@ -132,6 +132,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_create_new_folder_24" />
 
@@ -143,6 +144,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_compose"
+        android:contentDescription="@string/title_compose"
         app:backgroundTint="?attr/colorWarning"
         app:srcCompat="@drawable/baseline_warning_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_identities.xml b/app/src/main/res/layout/fragment_identities.xml
index 498e8d49e2..34b28f80c4 100644
--- a/app/src/main/res/layout/fragment_identities.xml
+++ b/app/src/main/res/layout/fragment_identities.xml
@@ -59,6 +59,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_add_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_messages.xml b/app/src/main/res/layout/fragment_messages.xml
index ba75bfe873..4216c81eb0 100644
--- a/app/src/main/res/layout/fragment_messages.xml
+++ b/app/src/main/res/layout/fragment_messages.xml
@@ -194,6 +194,7 @@
                 android:layout_gravity="end|bottom"
                 android:layout_margin="@dimen/fab_padding"
                 android:tint="?attr/colorFabForeground"
+                android:contentDescription="@string/title_reply"
                 app:backgroundTint="?attr/colorFabBackground"
                 app:layout_constraintBottom_toTopOf="@+id/sbThread"
                 app:layout_constraintEnd_toEndOf="parent"
@@ -206,6 +207,7 @@
                 android:background="?attr/selectableItemBackground"
                 android:padding="12dp"
                 android:tint="?attr/colorSeparator"
+                android:contentDescription="@string/title_accessibility_scroll_down"
                 app:layout_constraintBottom_toTopOf="@+id/sbThread"
                 app:layout_constraintEnd_toStartOf="@+id/ibUp"
                 app:layout_constraintHorizontal_chainStyle="packed"
@@ -219,6 +221,7 @@
                 android:background="?attr/selectableItemBackground"
                 android:padding="12dp"
                 android:tint="?attr/colorSeparator"
+                android:contentDescription="@string/title_accessibility_scroll_up"
                 app:layout_constraintBottom_toTopOf="@+id/sbThread"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintHorizontal_chainStyle="packed"
@@ -232,6 +235,7 @@
                 android:background="?attr/selectableItemBackground"
                 android:padding="12dp"
                 android:tint="?attr/colorSeparator"
+                android:contentDescription="@string/title_accessibility_filter_out_seen"
                 app:layout_constraintBottom_toTopOf="@+id/bottom_navigation"
                 app:layout_constraintEnd_toStartOf="@id/ibUnflagged"
                 app:layout_constraintHorizontal_chainStyle="packed"
@@ -245,6 +249,7 @@
                 android:background="?attr/selectableItemBackground"
                 android:padding="12dp"
                 android:tint="?attr/colorSeparator"
+                android:contentDescription="@string/title_accessibility_filter_out_unflagged"
                 app:layout_constraintBottom_toTopOf="@+id/bottom_navigation"
                 app:layout_constraintEnd_toEndOf="@+id/ibSnoozed"
                 app:layout_constraintStart_toEndOf="@id/ibSeen"
@@ -257,6 +262,7 @@
                 android:background="?attr/selectableItemBackground"
                 android:padding="12dp"
                 android:tint="?attr/colorSeparator"
+                android:contentDescription="@string/title_accessibility_filter_out_snoozed"
                 app:layout_constraintBottom_toTopOf="@+id/bottom_navigation"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toEndOf="@id/ibUnflagged"
@@ -324,6 +330,7 @@
         android:layout_marginBottom="90dp"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_more"
+        android:contentDescription="@string/title_more"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_more_vert_24" />
 
@@ -335,6 +342,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_search_server"
+        android:contentDescription="@string/title_search_server"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_youtube_searched_for_24" />
 
@@ -346,6 +354,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_compose"
+        android:contentDescription="@string/title_compose"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_edit_24" />
 
@@ -357,6 +366,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_compose"
+        android:contentDescription="@string/title_legend_section_folders"
         app:backgroundTint="?attr/colorWarning"
         app:srcCompat="@drawable/baseline_warning_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/fragment_rules.xml b/app/src/main/res/layout/fragment_rules.xml
index 60cda7ce17..d7676087ff 100644
--- a/app/src/main/res/layout/fragment_rules.xml
+++ b/app/src/main/res/layout/fragment_rules.xml
@@ -50,6 +50,7 @@
         android:layout_margin="@dimen/fab_padding"
         android:tint="?attr/colorFabForeground"
         android:tooltipText="@string/title_add"
+        android:contentDescription="@string/title_add"
         app:backgroundTint="?attr/colorFabBackground"
         app:srcCompat="@drawable/baseline_add_24" />
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 1ef2b33926..e71a0bdee5 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1055,6 +1055,12 @@
     <string name="title_accessibility_view_help">View help</string>
     <string name="title_accessibility_selected">Selected</string>
     <string name="title_accessibility_answered">Replied</string>
+    <string name="title_accessibility_scroll_down">Scroll down</string>
+    <string name="title_accessibility_scroll_up">Scroll up</string>
+    <string name="title_accessibility_filter_out_seen">Toggle read messages filter</string>
+    <string name="title_accessibility_filter_out_unflagged">Toggle starred messages filter</string>
+    <string name="title_accessibility_filter_out_snoozed">Toggle snoozed messages filter</string>
+    <string name="title_accessibility_edit">Edit</string>
 
     <string-array name="pollIntervalNames">
         <item>Always</item>