From 988674c4b3e8a656b11109434870a4ae263e7eb1 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Mon, 24 Dec 2018 13:41:49 +0000
Subject: [PATCH] Keep reference to inflater

---
 app/src/main/java/eu/faircode/email/AdapterAccount.java    | 4 +++-
 app/src/main/java/eu/faircode/email/AdapterAnswer.java     | 4 +++-
 app/src/main/java/eu/faircode/email/AdapterAttachment.java | 5 ++++-
 app/src/main/java/eu/faircode/email/AdapterFolder.java     | 5 ++++-
 app/src/main/java/eu/faircode/email/AdapterIdentity.java   | 4 +++-
 app/src/main/java/eu/faircode/email/AdapterLog.java        | 4 +++-
 app/src/main/java/eu/faircode/email/AdapterMessage.java    | 4 +++-
 app/src/main/java/eu/faircode/email/AdapterOperation.java  | 4 +++-
 8 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterAccount.java b/app/src/main/java/eu/faircode/email/AdapterAccount.java
index 5b755bd204..72fbbcd025 100644
--- a/app/src/main/java/eu/faircode/email/AdapterAccount.java
+++ b/app/src/main/java/eu/faircode/email/AdapterAccount.java
@@ -46,6 +46,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterAccount extends RecyclerView.Adapter<AdapterAccount.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
     private boolean debug;
 
     private List<EntityAccount> all = new ArrayList<>();
@@ -128,6 +129,7 @@ public class AdapterAccount extends RecyclerView.Adapter<AdapterAccount.ViewHold
 
     AdapterAccount(Context context) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
 
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
         this.debug = prefs.getBoolean("debug", false);
@@ -226,7 +228,7 @@ public class AdapterAccount extends RecyclerView.Adapter<AdapterAccount.ViewHold
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_account, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_account, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterAnswer.java b/app/src/main/java/eu/faircode/email/AdapterAnswer.java
index 409f975d14..32b4db91f8 100644
--- a/app/src/main/java/eu/faircode/email/AdapterAnswer.java
+++ b/app/src/main/java/eu/faircode/email/AdapterAnswer.java
@@ -41,6 +41,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterAnswer extends RecyclerView.Adapter<AdapterAnswer.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
 
     private List<EntityAnswer> all = new ArrayList<>();
     private List<EntityAnswer> filtered = new ArrayList<>();
@@ -85,6 +86,7 @@ public class AdapterAnswer extends RecyclerView.Adapter<AdapterAnswer.ViewHolder
 
     AdapterAnswer(Context context) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         setHasStableIds(true);
     }
 
@@ -179,7 +181,7 @@ public class AdapterAnswer extends RecyclerView.Adapter<AdapterAnswer.ViewHolder
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_answer, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_answer, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterAttachment.java b/app/src/main/java/eu/faircode/email/AdapterAttachment.java
index 7f2b807aec..eeffff8152 100644
--- a/app/src/main/java/eu/faircode/email/AdapterAttachment.java
+++ b/app/src/main/java/eu/faircode/email/AdapterAttachment.java
@@ -57,7 +57,9 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterAttachment extends RecyclerView.Adapter<AdapterAttachment.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
     private LifecycleOwner owner;
+
     private boolean readonly;
     private boolean confirm;
     private boolean debug;
@@ -307,6 +309,7 @@ public class AdapterAttachment extends RecyclerView.Adapter<AdapterAttachment.Vi
     AdapterAttachment(Context context, LifecycleOwner owner, boolean readonly) {
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         this.owner = owner;
         this.readonly = readonly;
         this.confirm = prefs.getBoolean("confirm", false);
@@ -402,7 +405,7 @@ public class AdapterAttachment extends RecyclerView.Adapter<AdapterAttachment.Vi
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_attachment, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_attachment, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterFolder.java b/app/src/main/java/eu/faircode/email/AdapterFolder.java
index 59deb67128..b807e0f39c 100644
--- a/app/src/main/java/eu/faircode/email/AdapterFolder.java
+++ b/app/src/main/java/eu/faircode/email/AdapterFolder.java
@@ -52,7 +52,9 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterFolder extends RecyclerView.Adapter<AdapterFolder.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
     private LifecycleOwner owner;
+
     private long account;
     private boolean debug;
     private int dp12;
@@ -370,6 +372,7 @@ public class AdapterFolder extends RecyclerView.Adapter<AdapterFolder.ViewHolder
 
     AdapterFolder(Context context, LifecycleOwner owner) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         this.owner = owner;
 
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
@@ -481,7 +484,7 @@ public class AdapterFolder extends RecyclerView.Adapter<AdapterFolder.ViewHolder
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_folder, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_folder, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterIdentity.java b/app/src/main/java/eu/faircode/email/AdapterIdentity.java
index 823ff2eec1..f8974633d9 100644
--- a/app/src/main/java/eu/faircode/email/AdapterIdentity.java
+++ b/app/src/main/java/eu/faircode/email/AdapterIdentity.java
@@ -43,6 +43,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterIdentity extends RecyclerView.Adapter<AdapterIdentity.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
 
     private List<TupleIdentityEx> all = new ArrayList<>();
     private List<TupleIdentityEx> filtered = new ArrayList<>();
@@ -120,6 +121,7 @@ public class AdapterIdentity extends RecyclerView.Adapter<AdapterIdentity.ViewHo
 
     AdapterIdentity(Context context) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         setHasStableIds(true);
     }
 
@@ -214,7 +216,7 @@ public class AdapterIdentity extends RecyclerView.Adapter<AdapterIdentity.ViewHo
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_identity, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_identity, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterLog.java b/app/src/main/java/eu/faircode/email/AdapterLog.java
index fba8b0dbf2..b1958b3948 100644
--- a/app/src/main/java/eu/faircode/email/AdapterLog.java
+++ b/app/src/main/java/eu/faircode/email/AdapterLog.java
@@ -37,6 +37,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterLog extends RecyclerView.Adapter<AdapterLog.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
 
     private List<EntityLog> all = new ArrayList<>();
     private List<EntityLog> filtered = new ArrayList<>();
@@ -65,6 +66,7 @@ public class AdapterLog extends RecyclerView.Adapter<AdapterLog.ViewHolder> {
 
     AdapterLog(Context context) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         setHasStableIds(true);
     }
 
@@ -149,7 +151,7 @@ public class AdapterLog extends RecyclerView.Adapter<AdapterLog.ViewHolder> {
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_log, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_log, parent, false));
     }
 
     @Override
diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index 8b16002ced..bc6818f671 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -106,6 +106,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
     private LifecycleOwner owner;
     private FragmentManager fragmentManager;
     private ViewType viewType;
@@ -1608,6 +1609,7 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                    ViewType viewType, boolean outgoing, int zoom, IProperties properties) {
         this.context = context;
         this.owner = owner;
+        this.inflater = LayoutInflater.from(context);
         this.fragmentManager = fragmentManager;
         this.viewType = viewType;
         this.outgoing = outgoing;
@@ -1674,7 +1676,7 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(
+        return new ViewHolder(inflater.inflate(
                 compact ? R.layout.item_message_compact : R.layout.item_message_normal,
                 parent,
                 false));
diff --git a/app/src/main/java/eu/faircode/email/AdapterOperation.java b/app/src/main/java/eu/faircode/email/AdapterOperation.java
index acee072151..4ed24930f2 100644
--- a/app/src/main/java/eu/faircode/email/AdapterOperation.java
+++ b/app/src/main/java/eu/faircode/email/AdapterOperation.java
@@ -43,6 +43,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.ViewHolder> {
     private Context context;
+    private LayoutInflater inflater;
     private LifecycleOwner owner;
 
     private List<TupleOperationEx> all = new ArrayList<>();
@@ -160,6 +161,7 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
 
     AdapterOperation(Context context, LifecycleOwner owner) {
         this.context = context;
+        this.inflater = LayoutInflater.from(context);
         this.owner = owner;
         setHasStableIds(true);
     }
@@ -245,7 +247,7 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
     @Override
     @NonNull
     public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
-        return new ViewHolder(LayoutInflater.from(context).inflate(R.layout.item_operation, parent, false));
+        return new ViewHolder(inflater.inflate(R.layout.item_operation, parent, false));
     }
 
     @Override