From 6032fad0991aac6f9bd4da4b1f14b7266675f6ed Mon Sep 17 00:00:00 2001 From: M66B Date: Tue, 9 Jul 2019 11:02:43 +0200 Subject: [PATCH] Switch to warning flag for authentication failures --- FAQ.md | 6 +- README.md | 1 + .../eu/faircode/email/AdapterMessage.java | 22 ++--- .../faircode/email/FragmentOptionsMisc.java | 2 +- .../res/layout/fragment_legend_messages.xml | 95 ++++++++++++------- .../main/res/layout/fragment_options_misc.xml | 17 +++- .../res/layout/include_message_compact.xml | 23 +++-- .../res/layout/include_message_normal.xml | 23 +++-- app/src/main/res/values/strings.xml | 1 + 9 files changed, 117 insertions(+), 73 deletions(-) diff --git a/FAQ.md b/FAQ.md index 0297b84074..c64df662a4 100644 --- a/FAQ.md +++ b/FAQ.md @@ -1624,9 +1624,9 @@ This is why texts with dots are sometimes incorrectly recognized as links, which Spam filtering, verification of the [DKIM](https://en.wikipedia.org/wiki/DomainKeys_Identified_Mail) signature and [SPF](https://en.wikipedia.org/wiki/Sender_Policy_Framework) authorization is a task of email servers, not of an email client. -However, FairEmail can show a small vertical warning stripe at the end of the message header -if DKIM, SPF or [DMARC](https://en.wikipedia.org/wiki/DMARC) authentication failed on the receiving server. -You can enable this in the settings. +However, FairEmail will show a small warning flag +when DKIM, SPF or [DMARC](https://en.wikipedia.org/wiki/DMARC) authentication failed on the receiving server. +You can enable/disable this in the miscellaneous settings.
diff --git a/README.md b/README.md index ea5206b853..a0e0f2bb8f 100644 --- a/README.md +++ b/README.md @@ -47,6 +47,7 @@ This app starts a foreground service with a low priority status bar notification * Confirm showing images to prevent tracking * Confirm opening links to prevent tracking and phishing * Automatically recognize and disable tracking images +* Warn when a message could not be [authenticated](https://github.com/M66B/open-source-email/blob/master/FAQ.md#user-content-faq92) ## Pro features diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java index 13e9487001..ec419ff73f 100644 --- a/app/src/main/java/eu/faircode/email/AdapterMessage.java +++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java @@ -207,7 +207,6 @@ public class AdapterMessage extends RecyclerView.Adapter 0 ? R.drawable.baseline_edit_24 : EntityFolder.getIcon(message.folderType)); @@ -657,6 +656,7 @@ public class AdapterMessage extends RecyclerView.Adapter config = new AsyncDifferConfig.Builder<>(DIFF_CALLBACK) diff --git a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java index fab14ec909..879bacb8af 100644 --- a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java +++ b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java @@ -243,7 +243,7 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc swSubscribedOnly.setChecked(prefs.getBoolean("subscribed_only", false)); swEnglish.setChecked(prefs.getBoolean("english", false)); - swAuthentication.setChecked(prefs.getBoolean("authentication", false)); + swAuthentication.setChecked(prefs.getBoolean("authentication", true)); swWatchdog.setChecked(prefs.getBoolean("watchdog", true)); swUpdates.setChecked(prefs.getBoolean("updates", true)); swUpdates.setVisibility(Helper.isPlayStoreInstall(getContext()) ? View.GONE : View.VISIBLE); diff --git a/app/src/main/res/layout/fragment_legend_messages.xml b/app/src/main/res/layout/fragment_legend_messages.xml index 78db8ca6f4..ff35537031 100644 --- a/app/src/main/res/layout/fragment_legend_messages.xml +++ b/app/src/main/res/layout/fragment_legend_messages.xml @@ -23,9 +23,9 @@ android:layout_height="wrap_content" android:contentDescription="@string/title_legend_thread" android:padding="12dp" - app:srcCompat="@drawable/baseline_message_24" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toTopOf="parent" /> + app:layout_constraintTop_toTopOf="parent" + app:srcCompat="@drawable/baseline_message_24" /> + app:layout_constraintTop_toBottomOf="@id/ivThread" + app:srcCompat="@drawable/baseline_format_size_24" /> + app:layout_constraintTop_toBottomOf="@id/ivZoom" + app:srcCompat="@drawable/baseline_edit_24" /> + + + + + app:layout_constraintTop_toBottomOf="@id/ivAuth" + app:srcCompat="@drawable/baseline_timelapse_24" /> + app:layout_constraintTop_toBottomOf="@id/ivSnoozed" + app:srcCompat="@drawable/baseline_playlist_add_24" /> + app:layout_constraintTop_toBottomOf="@id/ivBrowsed" + app:srcCompat="@drawable/baseline_reply_24" /> + app:layout_constraintTop_toBottomOf="@id/ivAnswered" + app:srcCompat="@drawable/baseline_notes_24" /> + app:layout_constraintTop_toBottomOf="@id/ivPlain" + app:srcCompat="@drawable/baseline_playlist_add_check_24" /> + app:layout_constraintTop_toBottomOf="@id/ivReceipt" + app:srcCompat="@drawable/baseline_attachment_24" /> + app:layout_constraintTop_toBottomOf="@id/tvAttachment" + app:srcCompat="@drawable/baseline_star_24" /> + app:layout_constraintTop_toBottomOf="@id/ivStarred" + app:srcCompat="@drawable/baseline_import_contacts_24" /> + app:layout_constraintTop_toBottomOf="@id/ivContacts" + app:srcCompat="@drawable/baseline_search_24" /> + app:layout_constraintTop_toBottomOf="@id/ivSearch" + app:srcCompat="@drawable/baseline_visibility_24" /> + app:layout_constraintTop_toBottomOf="@id/ivView" + app:srcCompat="@drawable/baseline_visibility_off_24" /> + app:layout_constraintTop_toBottomOf="@id/ivHide" + app:srcCompat="@drawable/baseline_cloud_download_24" /> + app:layout_constraintTop_toBottomOf="@id/ivDownload" + app:srcCompat="@drawable/baseline_image_24" /> + app:layout_constraintTop_toBottomOf="@id/ivExternalImage" + app:srcCompat="@drawable/baseline_photo_library_24" /> + app:layout_constraintTop_toBottomOf="@id/ivEmbeddedImage" + app:srcCompat="@drawable/baseline_broken_image_24" /> + + diff --git a/app/src/main/res/layout/include_message_compact.xml b/app/src/main/res/layout/include_message_compact.xml index 8e592b20e0..4d99170d47 100644 --- a/app/src/main/res/layout/include_message_compact.xml +++ b/app/src/main/res/layout/include_message_compact.xml @@ -115,6 +115,18 @@ app:layout_constraintStart_toEndOf="@id/paddingStart" app:layout_constraintTop_toTopOf="@+id/tvSubject" /> + + - - diff --git a/app/src/main/res/layout/include_message_normal.xml b/app/src/main/res/layout/include_message_normal.xml index 7ed554bfe3..be7101e4a9 100644 --- a/app/src/main/res/layout/include_message_normal.xml +++ b/app/src/main/res/layout/include_message_normal.xml @@ -140,6 +140,18 @@ app:layout_constraintStart_toEndOf="@id/ivAvatar" app:layout_constraintTop_toTopOf="@+id/tvFolder" /> + + - - diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 04c2d32f94..54ba765c73 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -643,6 +643,7 @@ Conversation Change text size Has draft + Authentication failed Is snoozed Is browsed or searched Has been answered