diff --git a/app/src/main/java/eu/faircode/email/FragmentDialogQuickActions.java b/app/src/main/java/eu/faircode/email/FragmentDialogQuickActions.java index fd967519c7..39f3fe9fe8 100644 --- a/app/src/main/java/eu/faircode/email/FragmentDialogQuickActions.java +++ b/app/src/main/java/eu/faircode/email/FragmentDialogQuickActions.java @@ -56,12 +56,12 @@ public class FragmentDialogQuickActions extends FragmentDialogBase { final CheckBox cbImportanceLow = dview.findViewById(R.id.cbImportanceLow); final CheckBox cbImportanceNormal = dview.findViewById(R.id.cbImportanceNormal); final CheckBox cbImportanceHigh = dview.findViewById(R.id.cbImportanceHigh); - final CheckBox cbInbox = dview.findViewById(R.id.cbInbox); + final CheckBox cbMove = dview.findViewById(R.id.cbMove); final CheckBox cbArchive = dview.findViewById(R.id.cbArchive); - final CheckBox cbJunk = dview.findViewById(R.id.cbJunk); final CheckBox cbTrash = dview.findViewById(R.id.cbTrash); final CheckBox cbDelete = dview.findViewById(R.id.cbDelete); - final CheckBox cbMove = dview.findViewById(R.id.cbMove); + final CheckBox cbJunk = dview.findViewById(R.id.cbJunk); + final CheckBox cbInbox = dview.findViewById(R.id.cbInbox); final CheckBox cbClear = dview.findViewById(R.id.cbClear); tvHint.setText(getString(R.string.title_quick_actions_hint, MAX_QUICK_ACTIONS)); @@ -75,12 +75,12 @@ public class FragmentDialogQuickActions extends FragmentDialogBase { cbImportanceLow.setChecked(prefs.getBoolean("more_importance_low", false)); cbImportanceNormal.setChecked(prefs.getBoolean("more_importance_normal", false)); cbImportanceHigh.setChecked(prefs.getBoolean("more_importance_high", false)); - cbInbox.setChecked(prefs.getBoolean("more_inbox", true)); + cbMove.setChecked(prefs.getBoolean("more_move", true)); cbArchive.setChecked(prefs.getBoolean("more_archive", true)); - cbJunk.setChecked(prefs.getBoolean("more_junk", true)); cbTrash.setChecked(prefs.getBoolean("more_trash", true)); cbDelete.setChecked(prefs.getBoolean("more_delete", false)); - cbMove.setChecked(prefs.getBoolean("more_move", true)); + cbJunk.setChecked(prefs.getBoolean("more_junk", true)); + cbInbox.setChecked(prefs.getBoolean("more_inbox", true)); cbClear.setChecked(prefs.getBoolean("more_clear", true)); return new AlertDialog.Builder(getContext()) @@ -99,12 +99,12 @@ public class FragmentDialogQuickActions extends FragmentDialogBase { editor.putBoolean("more_importance_low", cbImportanceLow.isChecked()); editor.putBoolean("more_importance_normal", cbImportanceNormal.isChecked()); editor.putBoolean("more_importance_high", cbImportanceHigh.isChecked()); - editor.putBoolean("more_inbox", cbInbox.isChecked()); + editor.putBoolean("more_move", cbMove.isChecked()); editor.putBoolean("more_archive", cbArchive.isChecked()); - editor.putBoolean("more_junk", cbJunk.isChecked()); editor.putBoolean("more_trash", cbTrash.isChecked()); editor.putBoolean("more_delete", cbDelete.isChecked()); - editor.putBoolean("more_move", cbMove.isChecked()); + editor.putBoolean("more_junk", cbJunk.isChecked()); + editor.putBoolean("more_inbox", cbInbox.isChecked()); editor.putBoolean("more_clear", cbClear.isChecked()); editor.apply(); sendResult(Activity.RESULT_OK); diff --git a/app/src/main/java/eu/faircode/email/FragmentMessages.java b/app/src/main/java/eu/faircode/email/FragmentMessages.java index c529de9960..0ae2cfc30e 100644 --- a/app/src/main/java/eu/faircode/email/FragmentMessages.java +++ b/app/src/main/java/eu/faircode/email/FragmentMessages.java @@ -300,12 +300,12 @@ public class FragmentMessages extends FragmentBase private ImageButton ibLowImportance; private ImageButton ibNormalImportance; private ImageButton ibHighImportance; - private ImageButton ibInbox; - private ImageButton ibJunk; + private ImageButton ibMove; + private ImageButton ibArchive; private ImageButton ibTrash; private ImageButton ibDelete; - private ImageButton ibArchive; - private ImageButton ibMove; + private ImageButton ibJunk; + private ImageButton ibInbox; private ImageButton ibMoreSettings; private FloatingActionButton fabSearch; private FloatingActionButton fabError; @@ -629,12 +629,12 @@ public class FragmentMessages extends FragmentBase ibLowImportance = view.findViewById(R.id.ibLowImportance); ibNormalImportance = view.findViewById(R.id.ibNormalImportance); ibHighImportance = view.findViewById(R.id.ibHighImportance); - ibInbox = view.findViewById(R.id.ibInbox); - ibJunk = view.findViewById(R.id.ibJunk); + ibMove = view.findViewById(R.id.ibMove); + ibArchive = view.findViewById(R.id.ibArchive); ibTrash = view.findViewById(R.id.ibTrash); ibDelete = view.findViewById(R.id.ibDelete); - ibArchive = view.findViewById(R.id.ibArchive); - ibMove = view.findViewById(R.id.ibMove); + ibJunk = view.findViewById(R.id.ibJunk); + ibInbox = view.findViewById(R.id.ibInbox); ibMoreSettings = view.findViewById(R.id.ibMoreSettings); fabSearch = view.findViewById(R.id.fabSearch); fabError = view.findViewById(R.id.fabError); @@ -1697,64 +1697,6 @@ public class FragmentMessages extends FragmentBase } }); - ibInbox.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View view) { - onActionMoveSelection(EntityFolder.INBOX, false); - } - }); - - ibInbox.setOnLongClickListener(new View.OnLongClickListener() { - @Override - public boolean onLongClick(View v) { - MoreResult result = (MoreResult) cardMore.getTag(); - if (result == null || !result.isJunk) - return false; - - if (result.hasPop && !result.hasImap) - onActionBlockSender(); - else if (!result.hasPop && result.hasImap) - onActionJunkSelection(); - - return true; - } - }); - - ibJunk.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - MoreResult result = (MoreResult) cardMore.getTag(); - if (result == null) - return; - - if (result.hasPop && !result.hasImap) - onActionBlockSender(); - else if (!result.hasPop && result.hasImap) - onActionJunkSelection(); - } - }); - - ibTrash.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - onActionMoveSelection(EntityFolder.TRASH, false); - } - }); - - ibDelete.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - onActionDeleteSelection(); - } - }); - - ibArchive.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - onActionMoveSelection(EntityFolder.ARCHIVE, false); - } - }); - Runnable runMoveTo = new RunnableEx("moveto") { @Override protected void delegate() { @@ -1811,6 +1753,64 @@ public class FragmentMessages extends FragmentBase } }); + ibArchive.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + onActionMoveSelection(EntityFolder.ARCHIVE, false); + } + }); + + ibTrash.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + onActionMoveSelection(EntityFolder.TRASH, false); + } + }); + + ibDelete.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + onActionDeleteSelection(); + } + }); + + ibJunk.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + MoreResult result = (MoreResult) cardMore.getTag(); + if (result == null) + return; + + if (result.hasPop && !result.hasImap) + onActionBlockSender(); + else if (!result.hasPop && result.hasImap) + onActionJunkSelection(); + } + }); + + ibInbox.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View view) { + onActionMoveSelection(EntityFolder.INBOX, false); + } + }); + + ibInbox.setOnLongClickListener(new View.OnLongClickListener() { + @Override + public boolean onLongClick(View v) { + MoreResult result = (MoreResult) cardMore.getTag(); + if (result == null || !result.isJunk) + return false; + + if (result.hasPop && !result.hasImap) + onActionBlockSender(); + else if (!result.hasPop && result.hasImap) + onActionJunkSelection(); + + return true; + } + }); + ibMoreSettings.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { @@ -7073,12 +7073,12 @@ public class FragmentMessages extends FragmentBase ibLowImportance.setVisibility(importance_low ? View.VISIBLE : View.GONE); ibNormalImportance.setVisibility(importance_normal ? View.VISIBLE : View.GONE); ibHighImportance.setVisibility(importance_high ? View.VISIBLE : View.GONE); - ibInbox.setVisibility(inbox ? View.VISIBLE : View.GONE); - ibJunk.setVisibility(junk ? View.VISIBLE : View.GONE); + ibMove.setVisibility(move ? View.VISIBLE : View.GONE); + ibArchive.setVisibility(archive ? View.VISIBLE : View.GONE); ibTrash.setVisibility(trash ? View.VISIBLE : View.GONE); ibDelete.setVisibility(delete ? View.VISIBLE : View.GONE); - ibArchive.setVisibility(archive ? View.VISIBLE : View.GONE); - ibMove.setVisibility(move ? View.VISIBLE : View.GONE); + ibJunk.setVisibility(junk ? View.VISIBLE : View.GONE); + ibInbox.setVisibility(inbox ? View.VISIBLE : View.GONE); cardMore.setTag(fabMore.isOrWillBeShown() ? result : null); cardMore.setVisibility(fabMore.isOrWillBeShown() ? View.VISIBLE : View.GONE); } diff --git a/app/src/main/res/layout/dialog_quick_actions.xml b/app/src/main/res/layout/dialog_quick_actions.xml index 2af7cda2bd..2598afa685 100644 --- a/app/src/main/res/layout/dialog_quick_actions.xml +++ b/app/src/main/res/layout/dialog_quick_actions.xml @@ -162,13 +162,13 @@ app:layout_constraintTop_toBottomOf="@id/cbImportanceNormal" /> + app:layout_constraintTop_toBottomOf="@id/cbMove" /> + app:layout_constraintTop_toBottomOf="@id/cbTrash" /> + app:layout_constraintTop_toBottomOf="@id/cbDelete" /> + app:layout_constraintTop_toBottomOf="@id/cbJunk" /> + app:layout_constraintTop_toBottomOf="@id/cbInbox" /> @@ -860,31 +860,31 @@ app:tint="@color/action_foreground" />