From 3dff252b37947485e2e46a97e31e709efce8421b Mon Sep 17 00:00:00 2001 From: M66B Date: Sun, 1 Sep 2019 18:59:51 +0200 Subject: [PATCH] Refactoring --- .../java/eu/faircode/email/ActivityView.java | 24 +++++++++---------- .../java/eu/faircode/email/AdapterFolder.java | 14 +++++------ .../eu/faircode/email/AdapterMessage.java | 14 +++++------ .../res/layout/include_message_addresses.xml | 10 ++++---- .../res/layout/include_message_compact.xml | 4 ++-- .../res/layout/include_message_normal.xml | 4 ++-- app/src/main/res/layout/include_nav.xml | 8 +++---- app/src/main/res/layout/item_folder.xml | 10 ++++---- .../main/res/layout/item_folder_select.xml | 12 +++++----- .../res/layout/item_folder_unselectable.xml | 4 ++-- 10 files changed, 52 insertions(+), 52 deletions(-) diff --git a/app/src/main/java/eu/faircode/email/ActivityView.java b/app/src/main/java/eu/faircode/email/ActivityView.java index bdad41b443..8dd68f8437 100644 --- a/app/src/main/java/eu/faircode/email/ActivityView.java +++ b/app/src/main/java/eu/faircode/email/ActivityView.java @@ -90,11 +90,11 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB private ActionBarDrawerToggle drawerToggle; private ScrollView drawerContainer; private RecyclerView rvAccount; - private ImageButton ivExpanderUnified; + private ImageButton ibExpanderUnified; private RecyclerView rvUnified; private RecyclerView rvFolder; private RecyclerView rvMenu; - private ImageButton ivExpanderExtra; + private ImageButton ibExpanderExtra; private RecyclerView rvMenuExtra; private Group grpUnified; @@ -164,8 +164,8 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB rvAccount.setAdapter(aadapter); // Unified system folders - ivExpanderUnified = drawerContainer.findViewById(R.id.ivExpanderUnified); - ivExpanderUnified.setVisibility(View.GONE); + ibExpanderUnified = drawerContainer.findViewById(R.id.ibExpanderUnified); + ibExpanderUnified.setVisibility(View.GONE); grpUnified = drawerContainer.findViewById(R.id.grpUnified); grpUnified.setVisibility(View.GONE); @@ -176,15 +176,15 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB rvUnified.setAdapter(uadapter); boolean unified_system = prefs.getBoolean("unified_system", false); - ivExpanderUnified.setImageLevel(unified_system ? 0 /* less */ : 1 /* more */); + ibExpanderUnified.setImageLevel(unified_system ? 0 /* less */ : 1 /* more */); grpUnified.setVisibility(unified_system ? View.VISIBLE : View.GONE); - ivExpanderUnified.setOnClickListener(new View.OnClickListener() { + ibExpanderUnified.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { boolean unified_system = !prefs.getBoolean("unified_system", false); prefs.edit().putBoolean("unified_system", unified_system).apply(); - ivExpanderUnified.setImageLevel(unified_system ? 0 /* less */ : 1 /* more */); + ibExpanderUnified.setImageLevel(unified_system ? 0 /* less */ : 1 /* more */); grpUnified.setVisibility(unified_system ? View.VISIBLE : View.GONE); } }); @@ -201,7 +201,7 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB rvMenu.setAdapter(madapter); // Extra menus - ivExpanderExtra = drawerContainer.findViewById(R.id.ivExpanderExtra); + ibExpanderExtra = drawerContainer.findViewById(R.id.ibExpanderExtra); rvMenuExtra = drawerContainer.findViewById(R.id.rvMenuExtra); LinearLayoutManager llm = new LinearLayoutManager(this); @@ -222,15 +222,15 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB rvMenuExtra.addItemDecoration(itemDecorator); boolean minimal = prefs.getBoolean("minimal", false); - ivExpanderExtra.setImageLevel(minimal ? 1 /* more */ : 0 /* less */); + ibExpanderExtra.setImageLevel(minimal ? 1 /* more */ : 0 /* less */); rvMenuExtra.setVisibility(minimal ? View.GONE : View.VISIBLE); - ivExpanderExtra.setOnClickListener(new View.OnClickListener() { + ibExpanderExtra.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { boolean minimal = !prefs.getBoolean("minimal", false); prefs.edit().putBoolean("minimal", minimal).apply(); - ivExpanderExtra.setImageLevel(minimal ? 1 /* more */ : 0 /* less */); + ibExpanderExtra.setImageLevel(minimal ? 1 /* more */ : 0 /* less */); rvMenuExtra.setVisibility(minimal ? View.GONE : View.VISIBLE); if (!minimal) new Handler().post(new Runnable() { @@ -399,7 +399,7 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB public void onChanged(List folders) { if (folders == null) folders = new ArrayList<>(); - ivExpanderUnified.setVisibility(folders.size() > 0 ? View.VISIBLE : View.GONE); + ibExpanderUnified.setVisibility(folders.size() > 0 ? View.VISIBLE : View.GONE); boolean unified_system = prefs.getBoolean("unified_system", false); grpUnified.setVisibility(unified_system && folders.size() > 0 ? View.VISIBLE : View.GONE); uadapter.set(folders); diff --git a/app/src/main/java/eu/faircode/email/AdapterFolder.java b/app/src/main/java/eu/faircode/email/AdapterFolder.java index f3c80fe687..ef3bb9831f 100644 --- a/app/src/main/java/eu/faircode/email/AdapterFolder.java +++ b/app/src/main/java/eu/faircode/email/AdapterFolder.java @@ -97,7 +97,7 @@ public class AdapterFolder extends RecyclerView.Adapter 0 ? View.VISIBLE : View.INVISIBLE); @@ -308,7 +308,7 @@ public class AdapterFolder extends RecyclerView.Adapter + app:constraint_referenced_ids="vSeparatorAddress,@+id/ibExpanderAddress" /> \ No newline at end of file diff --git a/app/src/main/res/layout/include_message_compact.xml b/app/src/main/res/layout/include_message_compact.xml index adca81c1d2..072aebd255 100644 --- a/app/src/main/res/layout/include_message_compact.xml +++ b/app/src/main/res/layout/include_message_compact.xml @@ -23,7 +23,7 @@ app:layout_constraintTop_toTopOf="parent" /> + app:layout_constraintTop_toBottomOf="@id/ibExpanderUnified" /> + app:layout_constraintTop_toBottomOf="@id/ibExpanderExtra" /> @@ -157,7 +157,7 @@ android:contentDescription="@string/title_legend_folder_type" android:paddingEnd="6dp" app:layout_constraintBottom_toBottomOf="@+id/tvType" - app:layout_constraintStart_toEndOf="@id/ivExpander" + app:layout_constraintStart_toEndOf="@id/ibExpander" app:layout_constraintTop_toTopOf="@+id/tvType" app:srcCompat="@drawable/baseline_inbox_24" /> @@ -224,7 +224,7 @@ android:text="Keywords" android:textAppearance="@android:style/TextAppearance.Small" app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintStart_toEndOf="@id/ivExpander" + app:layout_constraintStart_toEndOf="@id/ibExpander" app:layout_constraintTop_toBottomOf="@id/tvType" />