From 2add8a9ca501fba5445d29076b3ef414a3ea2b3e Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Tue, 5 Feb 2019 08:15:05 +0000
Subject: [PATCH] Fixed navigation for searching

---
 .../java/eu/faircode/email/ActivityView.java  |  5 ++-
 .../eu/faircode/email/AdapterMessage.java     |  3 +-
 .../eu/faircode/email/AdapterOperation.java   |  3 +-
 .../eu/faircode/email/FragmentMessages.java   |  7 +++-
 .../eu/faircode/email/ViewModelMessages.java  | 37 ++++++++++++-------
 5 files changed, 37 insertions(+), 18 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/ActivityView.java b/app/src/main/java/eu/faircode/email/ActivityView.java
index 5b99701ef8..eb7c988655 100644
--- a/app/src/main/java/eu/faircode/email/ActivityView.java
+++ b/app/src/main/java/eu/faircode/email/ActivityView.java
@@ -1070,13 +1070,16 @@ public class ActivityView extends ActivityBilling implements FragmentManager.OnB
     }
 
     private void onViewThread(Intent intent) {
-        if (getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.RESUMED))
+        boolean found = intent.getBooleanExtra("found", false);
+
+        if (!found && getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.RESUMED))
             getSupportFragmentManager().popBackStack("thread", FragmentManager.POP_BACK_STACK_INCLUSIVE);
 
         Bundle args = new Bundle();
         args.putLong("account", intent.getLongExtra("account", -1));
         args.putString("thread", intent.getStringExtra("thread"));
         args.putLong("id", intent.getLongExtra("id", -1));
+        args.putBoolean("found", found);
 
         FragmentMessages fragment = new FragmentMessages();
         fragment.setArguments(args);
diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index 421e3e80b3..662b5219b4 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -991,7 +991,8 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                             new Intent(ActivityView.ACTION_VIEW_THREAD)
                                     .putExtra("account", message.account)
                                     .putExtra("thread", message.thread)
-                                    .putExtra("id", message.id));
+                                    .putExtra("id", message.id)
+                                    .putExtra("found", viewType == ViewType.SEARCH));
                 }
             }
         }
diff --git a/app/src/main/java/eu/faircode/email/AdapterOperation.java b/app/src/main/java/eu/faircode/email/AdapterOperation.java
index 887b91f2b6..101147d542 100644
--- a/app/src/main/java/eu/faircode/email/AdapterOperation.java
+++ b/app/src/main/java/eu/faircode/email/AdapterOperation.java
@@ -147,7 +147,8 @@ public class AdapterOperation extends RecyclerView.Adapter<AdapterOperation.View
                                 new Intent(ActivityView.ACTION_VIEW_THREAD)
                                         .putExtra("account", message.account)
                                         .putExtra("thread", message.thread)
-                                        .putExtra("id", message.id));
+                                        .putExtra("id", message.id)
+                                        .putExtra("found", false));
                     }
 
                     @Override
diff --git a/app/src/main/java/eu/faircode/email/FragmentMessages.java b/app/src/main/java/eu/faircode/email/FragmentMessages.java
index 049401db24..7b66e3196e 100644
--- a/app/src/main/java/eu/faircode/email/FragmentMessages.java
+++ b/app/src/main/java/eu/faircode/email/FragmentMessages.java
@@ -116,6 +116,7 @@ public class FragmentMessages extends FragmentBase {
     private long folder;
     private String thread;
     private long id;
+    private boolean found;
     private String search;
     private boolean pane;
 
@@ -176,6 +177,7 @@ public class FragmentMessages extends FragmentBase {
         folder = args.getLong("folder", -1);
         thread = args.getString("thread");
         id = args.getLong("id", -1);
+        found = args.getBoolean("found", false);
         search = args.getString("search");
         pane = args.getBoolean("pane", false);
         primary = args.getLong("primary", -1);
@@ -376,7 +378,7 @@ public class FragmentMessages extends FragmentBase {
 
         if (viewType == AdapterMessage.ViewType.THREAD) {
             ViewModelMessages model = ViewModelProviders.of(getActivity()).get(ViewModelMessages.class);
-            model.observePrevNext(getViewLifecycleOwner(), id, new ViewModelMessages.IPrevNext() {
+            model.observePrevNext(getViewLifecycleOwner(), id, found, new ViewModelMessages.IPrevNext() {
                 @Override
                 public void onPrevious(boolean exists, Long id) {
                     previous = id;
@@ -1825,7 +1827,7 @@ public class FragmentMessages extends FragmentBase {
     private void loadMessages() {
         if (viewType == AdapterMessage.ViewType.THREAD && autonext) {
             ViewModelMessages model = ViewModelProviders.of(getActivity()).get(ViewModelMessages.class);
-            model.observePrevNext(getViewLifecycleOwner(), id, new ViewModelMessages.IPrevNext() {
+            model.observePrevNext(getViewLifecycleOwner(), id, found, new ViewModelMessages.IPrevNext() {
                 boolean once = false;
 
                 @Override
@@ -2224,6 +2226,7 @@ public class FragmentMessages extends FragmentBase {
                 nargs.putLong("account", message.account);
                 nargs.putString("thread", message.thread);
                 nargs.putLong("id", message.id);
+                nargs.putBoolean("found", found);
                 nargs.putBoolean("pane", pane);
                 nargs.putLong("primary", primary);
                 nargs.putBoolean("connected", connected);
diff --git a/app/src/main/java/eu/faircode/email/ViewModelMessages.java b/app/src/main/java/eu/faircode/email/ViewModelMessages.java
index 44cef29fbd..3c9bb1c1ac 100644
--- a/app/src/main/java/eu/faircode/email/ViewModelMessages.java
+++ b/app/src/main/java/eu/faircode/email/ViewModelMessages.java
@@ -32,18 +32,23 @@ import androidx.lifecycle.ViewModel;
 import androidx.paging.PagedList;
 
 public class ViewModelMessages extends ViewModel {
-    private Map<Boolean, LiveData<PagedList<TupleMessageEx>>> messages = new HashMap<>();
+    private Map<AdapterMessage.ViewType, LiveData<PagedList<TupleMessageEx>>> messages = new HashMap<>();
 
     void setMessages(AdapterMessage.ViewType viewType, LifecycleOwner owner, final LiveData<PagedList<TupleMessageEx>> messages) {
-        final boolean thread = (viewType == AdapterMessage.ViewType.THREAD);
-        this.messages.put(thread, messages);
+        if (viewType == AdapterMessage.ViewType.UNIFIED)
+            viewType = AdapterMessage.ViewType.FOLDER;
 
-        if (thread)
+        this.messages.put(viewType, messages);
+
+        if (viewType == AdapterMessage.ViewType.FOLDER)
+            this.messages.remove(AdapterMessage.ViewType.SEARCH);
+
+        if (viewType == AdapterMessage.ViewType.THREAD)
             owner.getLifecycle().addObserver(new LifecycleObserver() {
                 @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
                 public void onDestroyed() {
                     Log.i("Removed model thread");
-                    ViewModelMessages.this.messages.remove(thread);
+                    ViewModelMessages.this.messages.remove(AdapterMessage.ViewType.THREAD);
                 }
             });
         else {
@@ -57,16 +62,19 @@ public class ViewModelMessages extends ViewModel {
     }
 
     void observe(AdapterMessage.ViewType viewType, LifecycleOwner owner, Observer<PagedList<TupleMessageEx>> observer) {
-        if (owner.getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.INITIALIZED)) {
-            final boolean thread = (viewType == AdapterMessage.ViewType.THREAD);
-            messages.get(thread).observe(owner, observer);
-        }
+        if (viewType == AdapterMessage.ViewType.UNIFIED)
+            viewType = AdapterMessage.ViewType.FOLDER;
+
+        if (owner.getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.INITIALIZED))
+            messages.get(viewType).observe(owner, observer);
     }
 
     void removeObservers(AdapterMessage.ViewType viewType, LifecycleOwner owner) {
+        if (viewType == AdapterMessage.ViewType.UNIFIED)
+            viewType = AdapterMessage.ViewType.FOLDER;
+
         if (owner.getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.INITIALIZED)) {
-            boolean thread = (viewType == AdapterMessage.ViewType.THREAD);
-            LiveData<PagedList<TupleMessageEx>> list = messages.get(thread);
+            LiveData<PagedList<TupleMessageEx>> list = messages.get(viewType);
             if (list != null)
                 list.removeObservers(owner);
         }
@@ -77,8 +85,11 @@ public class ViewModelMessages extends ViewModel {
         messages.clear();
     }
 
-    void observePrevNext(LifecycleOwner owner, final long id, final IPrevNext intf) {
-        LiveData<PagedList<TupleMessageEx>> list = messages.get(false);
+    void observePrevNext(LifecycleOwner owner, final long id, boolean found, final IPrevNext intf) {
+        AdapterMessage.ViewType viewType =
+                (found ? AdapterMessage.ViewType.SEARCH : AdapterMessage.ViewType.FOLDER);
+
+        LiveData<PagedList<TupleMessageEx>> list = messages.get(viewType);
         if (list == null) {
             Log.w("Observe previous/next without list");
             return;