diff --git a/app/src/main/java/eu/faircode/email/FragmentOptionsDisplay.java b/app/src/main/java/eu/faircode/email/FragmentOptionsDisplay.java index 3ebbe95f61..f51c141a0a 100644 --- a/app/src/main/java/eu/faircode/email/FragmentOptionsDisplay.java +++ b/app/src/main/java/eu/faircode/email/FragmentOptionsDisplay.java @@ -181,6 +181,7 @@ public class FragmentOptionsDisplay extends FragmentBase implements SharedPrefer private TextView tvUnzipHint; private SwitchCompat swAttachmentsAlt; private SwitchCompat swThumbnails; + private SwitchCompat swPdfPreview; private SwitchCompat swListCount; private SwitchCompat swBundledFonts; @@ -220,7 +221,7 @@ public class FragmentOptionsDisplay extends FragmentBase implements SharedPrefer "hyphenation", "display_font", "contrast", "monospaced_pre", "text_separators", "collapse_quotes", "image_placeholders", "inline_images", "button_extra", - "unzip", "attachments_alt", "thumbnails", + "unzip", "attachments_alt", "thumbnails", "pdf_preview", "list_count", "bundled_fonts", "narrow_fonts", "parse_classes", "background_color", "text_color", "text_size", "text_font", "text_align", "text_titles", "authentication", "authentication_indicator" @@ -351,6 +352,7 @@ public class FragmentOptionsDisplay extends FragmentBase implements SharedPrefer tvUnzipHint = view.findViewById(R.id.tvUnzipHint); swAttachmentsAlt = view.findViewById(R.id.swAttachmentsAlt); swThumbnails = view.findViewById(R.id.swThumbnails); + swPdfPreview = view.findViewById(R.id.swPdfPreview); swListCount = view.findViewById(R.id.swListCount); swBundledFonts = view.findViewById(R.id.swBundledFonts); @@ -1304,6 +1306,14 @@ public class FragmentOptionsDisplay extends FragmentBase implements SharedPrefer @Override public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { prefs.edit().putBoolean("thumbnails", checked).apply(); + swPdfPreview.setEnabled(checked); + } + }); + + swPdfPreview.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() { + @Override + public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { + prefs.edit().putBoolean("pdf_preview", checked).apply(); } }); @@ -1644,6 +1654,8 @@ public class FragmentOptionsDisplay extends FragmentBase implements SharedPrefer swUnzip.setChecked(prefs.getBoolean("unzip", !BuildConfig.PLAY_STORE_RELEASE)); swAttachmentsAlt.setChecked(prefs.getBoolean("attachments_alt", false)); swThumbnails.setChecked(prefs.getBoolean("thumbnails", true)); + swPdfPreview.setChecked(prefs.getBoolean("pdf_preview", true)); + swPdfPreview.setEnabled(swThumbnails.isChecked()); swListCount.setChecked(prefs.getBoolean("list_count", false)); swBundledFonts.setChecked(prefs.getBoolean("bundled_fonts", true)); diff --git a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java index 9fc4f89854..9564307071 100644 --- a/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java +++ b/app/src/main/java/eu/faircode/email/FragmentOptionsMisc.java @@ -240,7 +240,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc private SwitchCompat swNativeDkim; private SwitchCompat swNativeArc; private EditText etNativeArcWhitelist; - private SwitchCompat swPdfPreview; private SwitchCompat swWebp; private SwitchCompat swEasyCorrect; private SwitchCompat swInfra; @@ -313,7 +312,7 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc "max_backoff_power", "logarithmic_backoff", "exact_alarms", "native_dkim", "native_arc", "native_arc_whitelist", - "pdf_preview", "webp", "easy_correct", "infra", "tld_flags", "dup_msgids", "thread_byref", "mdn", + "webp", "easy_correct", "infra", "tld_flags", "dup_msgids", "thread_byref", "mdn", "app_chooser", "delete_confirmation", "global_keywords", "test_iab" }; @@ -503,7 +502,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc swNativeDkim = view.findViewById(R.id.swNativeDkim); swNativeArc = view.findViewById(R.id.swNativeArc); etNativeArcWhitelist = view.findViewById(R.id.etNativeArcWhitelist); - swPdfPreview = view.findViewById(R.id.swPdfPreview); swWebp = view.findViewById(R.id.swWebp); swEasyCorrect = view.findViewById(R.id.swEasyCorrect); swInfra = view.findViewById(R.id.swInfra); @@ -1888,13 +1886,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc } }); - swPdfPreview.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() { - @Override - public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { - prefs.edit().putBoolean("pdf_preview", checked).apply(); - } - }); - swWebp.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() { @Override public void onCheckedChanged(CompoundButton compoundButton, boolean checked) { @@ -2725,7 +2716,6 @@ public class FragmentOptionsMisc extends FragmentBase implements SharedPreferenc swNativeArc.setChecked(prefs.getBoolean("native_arc", true)); etNativeArcWhitelist.setEnabled(swNativeDkim.isEnabled() && swNativeDkim.isChecked()); etNativeArcWhitelist.setText(prefs.getString("native_arc_whitelist", null)); - swPdfPreview.setChecked(prefs.getBoolean("pdf_preview", true)); swWebp.setChecked(prefs.getBoolean("webp", true)); swEasyCorrect.setChecked(prefs.getBoolean("easy_correct", false)); swInfra.setChecked(prefs.getBoolean("infra", false)); diff --git a/app/src/main/res/layout/fragment_options_display.xml b/app/src/main/res/layout/fragment_options_display.xml index 6ffd0ed79b..66e588cdf1 100644 --- a/app/src/main/res/layout/fragment_options_display.xml +++ b/app/src/main/res/layout/fragment_options_display.xml @@ -2023,6 +2023,18 @@ app:layout_constraintTop_toBottomOf="@id/swAttachmentsAlt" app:switchPadding="12dp" /> + + - - Show contents of compressed attachments Show attachments after the message text Show image thumbnails after the message text + Show PDF thumbnails Default message text zoom: %1$s %% Zoom message text also in the message editor Zoom original messages to fit the screen @@ -909,7 +910,6 @@ Use exact timers Native DKIM verification Native ARC verification - PDF preview Webp Easy correct Show infrastructure