From 14f4fd6b7f279b0c8b06a1c809770610fc88f07b Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Wed, 14 Aug 2019 13:18:42 +0200
Subject: [PATCH] Refactoring

---
 .../main/java/eu/faircode/email/AdapterMessage.java    |  5 +++--
 app/src/main/res/layout/include_message_compact.xml    | 10 ----------
 app/src/main/res/layout/include_message_normal.xml     | 10 ----------
 app/src/main/res/layout/item_message_compact.xml       | 10 ++++++++++
 app/src/main/res/layout/item_message_normal.xml        | 10 ++++++++++
 5 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index 85b7d60921..766926e4fa 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -234,6 +234,8 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
             BottomNavigationView.OnNavigationItemSelectedListener {
         private CardView card;
         private View view;
+        private View vwRipple;
+
         private CardView vwColor;
         private ImageView ivExpander;
         private ImageView ivFlagged;
@@ -256,7 +258,6 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
         private TextView tvPreview;
         private TextView tvError;
         private ContentLoadingProgressBar pbLoading;
-        private View vwRipple;
 
         private View vsBody;
 
@@ -336,6 +337,7 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
 
             card = itemView.findViewById(R.id.card);
             view = itemView.findViewById(R.id.clItem);
+            vwRipple = itemView.findViewById(R.id.vwRipple);
 
             vwColor = itemView.findViewById(R.id.vwColor);
             ivExpander = itemView.findViewById(R.id.ivExpander);
@@ -359,7 +361,6 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
             ivThread = itemView.findViewById(R.id.ivThread);
             tvError = itemView.findViewById(R.id.tvError);
             pbLoading = itemView.findViewById(R.id.pbLoading);
-            vwRipple = itemView.findViewById(R.id.vwRipple);
 
             if (!cards) {
                 FrameLayout.LayoutParams lparam = (FrameLayout.LayoutParams) card.getLayoutParams();
diff --git a/app/src/main/res/layout/include_message_compact.xml b/app/src/main/res/layout/include_message_compact.xml
index 248d876bb0..4d484c856f 100644
--- a/app/src/main/res/layout/include_message_compact.xml
+++ b/app/src/main/res/layout/include_message_compact.xml
@@ -319,14 +319,4 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
-
-    <View
-        android:id="@+id/vwRipple"
-        android:layout_width="0dp"
-        android:layout_height="0dp"
-        android:background="?android:attr/selectableItemBackground"
-        app:layout_constraintBottom_toBottomOf="@id/paddingBottom"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent" />
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/app/src/main/res/layout/include_message_normal.xml b/app/src/main/res/layout/include_message_normal.xml
index 7649d5c061..c21cd6f771 100644
--- a/app/src/main/res/layout/include_message_normal.xml
+++ b/app/src/main/res/layout/include_message_normal.xml
@@ -312,14 +312,4 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
-
-    <View
-        android:id="@+id/vwRipple"
-        android:layout_width="0dp"
-        android:layout_height="0dp"
-        android:background="?android:attr/selectableItemBackground"
-        app:layout_constraintBottom_toBottomOf="@id/paddingBottom"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent" />
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/app/src/main/res/layout/item_message_compact.xml b/app/src/main/res/layout/item_message_compact.xml
index 6d43ff0d7e..da68312f2d 100644
--- a/app/src/main/res/layout/item_message_compact.xml
+++ b/app/src/main/res/layout/item_message_compact.xml
@@ -31,6 +31,16 @@
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="parent" />
 
+            <View
+                android:id="@+id/vwRipple"
+                android:layout_width="0dp"
+                android:layout_height="0dp"
+                android:background="?android:attr/selectableItemBackground"
+                app:layout_constraintBottom_toBottomOf="@id/inHeader"
+                app:layout_constraintEnd_toEndOf="@id/inHeader"
+                app:layout_constraintStart_toStartOf="@id/inHeader"
+                app:layout_constraintTop_toTopOf="@id/inHeader" />
+
             <ViewStub
                 android:id="@+id/vsBody"
                 android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/item_message_normal.xml b/app/src/main/res/layout/item_message_normal.xml
index b94a007ab0..3e884a8622 100644
--- a/app/src/main/res/layout/item_message_normal.xml
+++ b/app/src/main/res/layout/item_message_normal.xml
@@ -31,6 +31,16 @@
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="parent" />
 
+            <View
+                android:id="@+id/vwRipple"
+                android:layout_width="0dp"
+                android:layout_height="0dp"
+                android:background="?android:attr/selectableItemBackground"
+                app:layout_constraintBottom_toBottomOf="@id/inHeader"
+                app:layout_constraintEnd_toEndOf="@id/inHeader"
+                app:layout_constraintStart_toStartOf="@id/inHeader"
+                app:layout_constraintTop_toTopOf="@id/inHeader" />
+
             <ViewStub
                 android:id="@+id/vsBody"
                 android:layout_width="match_parent"